perf: reduce fixed sleeps in test mode#1127
Closed
vringar wants to merge 1 commit intorefactor/storage-interfacefrom
Closed
perf: reduce fixed sleeps in test mode#1127vringar wants to merge 1 commit intorefactor/storage-interfacefrom
vringar wants to merge 1 commit intorefactor/storage-interfacefrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor/storage-interface #1127 +/- ##
==============================================================
+ Coverage 40.54% 43.31% +2.77%
==============================================================
Files 39 39
Lines 3611 3613 +2
==============================================================
+ Hits 1464 1565 +101
+ Misses 2147 2048 -99 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
182967b to
d22e33c
Compare
aa79ddd to
d333dbf
Compare
Make the 2s CommandSequence drain sleep and 5s FinalizeCommand sleep configurable based on manager_params.testing. In test mode, use 0.1s instead, significantly reducing per-visit overhead.
d22e33c to
d8a34a1
Compare
d333dbf to
f286084
Compare
Contributor
Author
|
Folded into #1128 — sleep reductions only make sense alongside the event-driven replacement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manager_params.testingis Truemanager_params.testingis TrueThese are stopgap sleeps (documented as support for #135) that add ~7s per visit in tests.
Stacked on #1126.