perf: event-driven completion signaling#1128
Closed
vringar wants to merge 2 commits intorefactor/storage-interfacefrom
Closed
perf: event-driven completion signaling#1128vringar wants to merge 2 commits intorefactor/storage-interfacefrom
vringar wants to merge 2 commits intorefactor/storage-interfacefrom
Conversation
Codecov Report❌ Patch coverage is ❌ Your project check has failed because the head coverage (35.25%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## refactor/storage-interface #1128 +/- ##
==============================================================
- Coverage 35.94% 35.25% -0.70%
==============================================================
Files 39 39
Lines 3611 3617 +6
==============================================================
- Hits 1298 1275 -23
- Misses 2313 2342 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vringar
force-pushed
the
refactor/event-driven-completion
branch
from
31054e1 to
e450b63
Compare
vringar
force-pushed
the
refactor/reduce-sleeps
branch
from
182967b to
d22e33c
Compare
vringar
force-pushed
the
refactor/reduce-sleeps
branch
from
d22e33c to
d8a34a1
Compare
vringar
force-pushed
the
refactor/event-driven-completion
branch
from
e450b63 to
09e5fc7
Compare
vringar
changed the base branch from
refactor/reduce-sleeps
to
refactor/storage-interface
vringar
force-pushed
the
refactor/event-driven-completion
branch
from
09e5fc7 to
8a2744c
Compare
Reduce update_completion_queue sleep from 5s to 0.5s so finalized visits reach the completion queue faster. Keep as fallback for the blocking get() on the TaskManager side.
vringar
force-pushed
the
refactor/event-driven-completion
branch
from
8a2744c to
b896b91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sleep(1)polling in_mark_command_sequences_completewith blockingcompletion_queue.get(timeout=1), so callbacks fire as soon as data is availableupdate_completion_queuepolling interval from 5s to 0.5s in StorageControllerCombined, this reduces visit completion latency from up to 6s to near-instant.
Stacked on #1127.