🐛 Update dependencies of goreleaser to be compatible with go 1.25 #2389
Conversation
Trying to build goreleaser (i.e. bingo get) using golang 1.25 fails due to a dependency incompatibility with golang 1.25. Use a replace statement to update golang.org/x/tools to v0.26.0, this is the minimum updated version that will work with golang 1.25. Tested with golang 1.25.3 and 1.24.6 Signed-off-by: Todd Short <tshort@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2389 +/- ##
==========================================
- Coverage 73.05% 68.82% -4.23%
==========================================
Files 100 100
Lines 7641 7641
==========================================
- Hits 5582 5259 -323
- Misses 1623 1947 +324
+ Partials 436 435 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
closing in favor of #2390 |
1 participant
Trying to build goreleaser (i.e. bingo get) using golang 1.25 fails due to a dependency incompatibility with golang 1.25.
Use a replace statement to update golang.org/x/tools to v0.26.0, this is the minimum updated version that will work with golang 1.25.
Tested with golang 1.25.3 and 1.24.6
Description
Reviewer Checklist