Skip to content

Conversation

@tmshort
Copy link
Contributor

@tmshort tmshort commented Dec 17, 2025

This version requires golang 1.24.6 (which is our max version) but also supports golang 1.25.3. This is the maximum version of goreleaser that we can move to given our golang version constraints of having to support golang 1.24 while moving to golang 1.25.

Updates the config file to v2

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

This version requires golang 1.24.6 (which is our max version) but also
supports golang 1.25.3. This is the maximum version of goreleaser that
we can move to given our golang version constraints of having to support
golang 1.24 while moving to golang 1.25.

Updates the config file to v2

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort requested a review from a team as a code owner December 17, 2025 15:02
@openshift-ci openshift-ci bot requested review from OchiengEd and pedjak December 17, 2025 15:02
@tmshort
Copy link
Contributor Author

tmshort commented Dec 17, 2025

Alternative to #2389

@netlify
Copy link

netlify bot commented Dec 17, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit a7c67fd
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6942c61a3214870008ccf752
😎 Deploy Preview https://deploy-preview-2390--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@grokspawn
Copy link
Contributor

I prefer this over #2389, but do we have any way to test the go-releaser changes (short of merging this and cutting a release)?

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.79%. Comparing base (aaffdeb) to head (a7c67fd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2390      +/-   ##
==========================================
- Coverage   73.05%   68.79%   -4.26%     
==========================================
  Files         100      100              
  Lines        7641     7641              
==========================================
- Hits         5582     5257     -325     
- Misses       1623     1948     +325     
  Partials      436      436              
Flag Coverage Δ
e2e 43.90% <ø> (+0.11%) ⬆️
experimental-e2e 13.68% <ø> (-35.07%) ⬇️
unit 57.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
Copy link
Contributor Author

tmshort commented Dec 17, 2025

I prefer this over #2389, but do we have any way to test the go-releaser changes (short of merging this and cutting a release)?

There's a go releaser CI job (that passed). I also ran make release locally, with both golang 1.24.6 and 1.25.3.

@perdasilva
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Dec 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2025
@perdasilva
Copy link
Contributor

I also think this is better than the alternative

Copy link
Contributor

@pedjak pedjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Dec 17, 2025

/override codecov/project

@openshift-ci
Copy link

openshift-ci bot commented Dec 17, 2025

@tmshort: Overrode contexts on behalf of tmshort: codecov/project

Details

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit c5d9fed into operator-framework:main Dec 17, 2025
27 of 28 checks passed
@tmshort tmshort deleted the update-goreleaser branch December 18, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants