-
Notifications
You must be signed in to change notification settings - Fork 69
🌱 Update goreleaser to v2.11.2 #2390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Update goreleaser to v2.11.2 #2390
Conversation
This version requires golang 1.24.6 (which is our max version) but also supports golang 1.25.3. This is the maximum version of goreleaser that we can move to given our golang version constraints of having to support golang 1.24 while moving to golang 1.25. Updates the config file to v2 Signed-off-by: Todd Short <tshort@redhat.com>
|
Alternative to #2389 |
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
I prefer this over #2389, but do we have any way to test the go-releaser changes (short of merging this and cutting a release)? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2390 +/- ##
==========================================
- Coverage 73.05% 68.79% -4.26%
==========================================
Files 100 100
Lines 7641 7641
==========================================
- Hits 5582 5257 -325
- Misses 1623 1948 +325
Partials 436 436
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There's a go releaser CI job (that passed). I also ran |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I also think this is better than the alternative |
pedjak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/override codecov/project |
|
@tmshort: Overrode contexts on behalf of tmshort: codecov/project DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
c5d9fed
into
operator-framework:main
This version requires golang 1.24.6 (which is our max version) but also supports golang 1.25.3. This is the maximum version of goreleaser that we can move to given our golang version constraints of having to support golang 1.24 while moving to golang 1.25.
Updates the config file to v2
Description
Reviewer Checklist