Skip to content

Conversation

@dsellick-opti
Copy link
Contributor

@dsellick-opti dsellick-opti commented Sep 4, 2024

User description

…les with appropriate names to make app setup clearer

Description of Changes

Moved credentials in QA app to local variables rather than passing string directly into the builder improve the codes readability - no function change

Breaking Changes

  • None

Release Checklist

Prepare:

  • Detail any breaking changes. Breaking changes require a new major version number, and a migration guide in wiki / README.md

Bump versions in:

  • CHANGELOG.md
  • gradle.properties
  • add links to newly created wiki pages to readme
  • Update major version numbers in wiki (basic integration + push guides)

Integration tests

T&T Only

  • Init SDK with only optimove credentials
  • Associate customer
  • Associate email
  • Track events

Mobile Only

  • Init SDK with all credentials
  • Track events
  • Associate customer (verify both backends)
  • Register for push
  • Opt-in for In-App
  • Send test push
  • Send test In-App
  • Receive / trigger deep link handler (In-App/Push)
  • Receive / trigger the content extension, render image and action buttons for push
  • Verify push opened handler

Deferred Deep Links

  • With app installed, trigger deep link handler
  • With app uninstalled, follow deep link, install test bundle, verify deep link read from Clipboard, trigger deep link handler

Combined

  • Track event for T&T, verify push received
  • Trigger scheduled campaign, verify push received
  • Trigger scheduled campaign, verify In-App received

Release Procedure

  • Squash and merge dev to master
  • Delete branch once merged

Generated description

Below is a concise technical summary of the changes proposed in this PR:
Refactors the initialization of the Optimove SDK within the QA application by replacing direct string literals with local variables for API keys, improving code readability. Updates the MyApplication class to use these new variables when configuring the SDK.

Latest Contributors(2)
UserCommitDate
vvoicehovicsAB-251460-API-to-set-n...June 20, 2025
daniel_c@optimove.comupdate-the-documentationApril 30, 2025
This pull request is reviewed by Baz. Review like a pro on (Baz).

…les with appropriate names to make app setup clearer
@pr-work-item-validator
Copy link

👋 Hey @dsellick-opti,

❗️ Work Item link check failed: There is no Work Item linked to this PR.

🧩 Please add the Work Item ID to the PR title or description using the "Edit" option in the format below:
AB#XXXXX - replace X with a valid Work Item ID.

🟢 Once added, the validation will automatically run again!

Comment on lines +33 to +37
String optimoveApiKey = "";
String optimobileApiKey = "";

Optimove.initialize(this, new OptimoveConfig.Builder(
null,
"base64Creds")
optimoveApiKey, optimobileApiKey)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are empty API keys intentional here? Most SDKs fail initialization with empty strings rather than null values.

Suggested change
String optimoveApiKey = "";
String optimobileApiKey = "";
Optimove.initialize(this, new OptimoveConfig.Builder(
null,
"base64Creds")
optimoveApiKey, optimobileApiKey)
String optimoveApiKey = null;
String optimobileApiKey = null;
Optimove.initialize(this, new OptimoveConfig.Builder(
optimoveApiKey, optimobileApiKey)

Finding type: Logical Bugs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants