Skip to content

QA app initialisation tidy up #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dsellick-opti wants to merge 1 commit into
base: master
Choose a base branch
from
Open

QA app initialisation tidy up #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions OptimoveSDK/app/src/main/java/com/optimove/android/optimovemobilesdk/MyApplication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,11 @@ public static void askForOverlayPermissions() {
public void onCreate() {
super.onCreate();

String optimoveApiKey = "";
String optimobileApiKey = "";

Optimove.initialize(this, new OptimoveConfig.Builder(
null,
"base64Creds")
optimoveApiKey, optimobileApiKey)
Comment on lines +33 to +37
Copy link
Contributor

@baz-reviewer baz-reviewer bot Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are empty API keys intentional here? Most SDKs fail initialization with empty strings rather than null values.

Suggested change
String optimoveApiKey = "";
String optimobileApiKey = "";
Optimove.initialize(this, new OptimoveConfig.Builder(
null,
"base64Creds")
optimoveApiKey, optimobileApiKey)
String optimoveApiKey = null;
String optimobileApiKey = null;
Optimove.initialize(this, new OptimoveConfig.Builder(
optimoveApiKey, optimobileApiKey)

Finding type: Logical Bugs

.enableInAppMessaging(OptimoveConfig.InAppConsentStrategy.AUTO_ENROLL)
.build());
// Shouldn't be called unless explicitly told to
Expand Down