Open
Conversation
leandrumartin
requested changes
Mar 27, 2026
Collaborator
leandrumartin
left a comment
leandrumartin
left a comment
There was a problem hiding this comment.
I'm a little confused by this PR. The code changes don't seem to line up with what you've described in the summary, and they don't really address the problem described in the issue. I'm having trouble understanding the reasons for the changes made here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Closes #219
This update refactors how boneset data is accessed and improves code generalization in preparation for supporting multiple bonesets.
Changes
Refactored functions that previously relied on the BONESET_JSON_URL constant.
These functions no longer fetch data from a single JSON file.
Instead, they now iterate through all JSON files within the boneset/ directory in the database, allowing support for multiple bonesets.
Reviewed and updated comments throughout the codebase:
Removed references to the pelvis boneset where the functionality is not pelvis-specific.
Reworded comments to reflect generalized behavior applicable to all bonesets.
Preserved comments that document pelvis-specific logic, edge cases, or exceptions.