fan schematic and circuit changes#421
Open
ThomasPautler952194 wants to merge 2 commits intodevelopfrom
Open
Conversation
leandrumartin
previously approved these changes
Nov 3, 2025
Collaborator
leandrumartin
left a comment
leandrumartin
left a comment
There was a problem hiding this comment.
It looks like the green wire on the motor is now connected to GPIO 17, so that it is now connected to both GPIO 17 and 18. Is this right? I would think that it should be connected to GPIO 18 (as that it what is listed in application.yml) and a GND pin.
Collaborator
|
Also, I would recommend making the circuit diagram use an extension board (like the red extension boards you see in the other circuit diagrams in our documentation) so it's easier to visualize which pin the wires are connected to. There should be a "T-cobbler" component included in Fritzing that you can put in the diagram. |
Collaborator
|
Quick reminder to finish this issue too. Revert the last commit where the test class was added, and make the changes to the diagram. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes to the Circuit and schematic diagrams to get rid of support for a temperature sensor in the fan.adoc documentation.