Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates DNS names for UI frontend URLs in the AWS Elastic Beanstalk environment configuration, shortening them from "tools-support-{env}" to more concise names aligned with a standardized naming scheme.
Changes:
- Updated production UI frontend URL from
tools-support-prodtotools-ui - Updated beta UI frontend URL from
tools-support-betatotools-dev-ui
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "jwtJWKSURI": "https://lti-dev.canvas.ox.ac.uk/.well-known/jwks.json" | ||
| "ltiIssuer": "https://lti-dev.canvas.ox.ac.uk" | ||
| "uiFrontendUrl": "https://tools-support-beta.canvas-tools.app" | ||
| "uiFrontendUrl": "https://tools-dev-ui.canvas-tools.app/" |
There was a problem hiding this comment.
The naming pattern differs from the production environment. The prod URL uses "tools-ui" while beta uses "tools-dev-ui". Looking at the AccountTypeMappings (lines 100-102), the non-prod pattern consistently uses "-dev" suffix (e.g., "lti-dev", "proxy-dev", "tools-dev"). However, the beta URL adds "-dev" between "tools" and "ui" instead of using a consistent prefix or suffix pattern. Consider whether "tools-dev-ui" is the intended pattern or if it should be "tools-ui-dev" to better align with other naming conventions.
| "uiFrontendUrl": "https://tools-dev-ui.canvas-tools.app/" | |
| "uiFrontendUrl": "https://tools-ui-dev.canvas-tools.app/" |
| "jwtJWKSURI": "https://lti.canvas.ox.ac.uk/.well-known/jwks.json" | ||
| "ltiIssuer": "https://lti.canvas.ox.ac.uk" | ||
| "uiFrontendUrl": "https://tools-support-prod.canvas-tools.app" | ||
| "uiFrontendUrl": "https://tools-ui.canvas-tools.app/" |
There was a problem hiding this comment.
The production URL ends with a trailing slash, but other URLs in the same configuration (lines 108-110) do not have trailing slashes. This inconsistency could lead to issues with URL matching or CORS configuration. Consider removing the trailing slash to align with the existing URL patterns in the file.
| "uiFrontendUrl": "https://tools-ui.canvas-tools.app/" | |
| "uiFrontendUrl": "https://tools-ui.canvas-tools.app" |
| "jwtJWKSURI": "https://lti-dev.canvas.ox.ac.uk/.well-known/jwks.json" | ||
| "ltiIssuer": "https://lti-dev.canvas.ox.ac.uk" | ||
| "uiFrontendUrl": "https://tools-support-beta.canvas-tools.app" | ||
| "uiFrontendUrl": "https://tools-dev-ui.canvas-tools.app/" |
There was a problem hiding this comment.
The beta URL ends with a trailing slash, but other URLs in the same configuration (lines 116-118) do not have trailing slashes. This inconsistency could lead to issues with URL matching or CORS configuration. Consider removing the trailing slash to align with the existing URL patterns in the file.
| "uiFrontendUrl": "https://tools-dev-ui.canvas-tools.app/" | |
| "uiFrontendUrl": "https://tools-dev-ui.canvas-tools.app" |
No description provided.