Skip to content

AB#72068 Shorten and align DNS names. #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buckett merged 1 commit into from
Jan 26, 2026
Merged

AB#72068 Shorten and align DNS names. #200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions aws/eb-env.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,15 +108,15 @@ Mappings:
"jwtIssuer": "https://lti.canvas.ox.ac.uk"
"jwtJWKSURI": "https://lti.canvas.ox.ac.uk/.well-known/jwks.json"
"ltiIssuer": "https://lti.canvas.ox.ac.uk"
"uiFrontendUrl": "https://tools-support-prod.canvas-tools.app"
"uiFrontendUrl": "https://tools-ui.canvas-tools.app/"
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The production URL ends with a trailing slash, but other URLs in the same configuration (lines 108-110) do not have trailing slashes. This inconsistency could lead to issues with URL matching or CORS configuration. Consider removing the trailing slash to align with the existing URL patterns in the file.

Suggested change
"uiFrontendUrl": "https://tools-ui.canvas-tools.app/"
"uiFrontendUrl": "https://tools-ui.canvas-tools.app"

Copilot uses AI. Check for mistakes.
beta:
"mngdUpdates": "MON:06:00"
# We have an additional profile that unsets things on the non-prod account
"springProfile": "aws,nonprod" #SPRING_PROFILES_ACTIVE
"jwtIssuer": "https://lti-dev.canvas.ox.ac.uk"
"jwtJWKSURI": "https://lti-dev.canvas.ox.ac.uk/.well-known/jwks.json"
"ltiIssuer": "https://lti-dev.canvas.ox.ac.uk"
"uiFrontendUrl": "https://tools-support-beta.canvas-tools.app"
"uiFrontendUrl": "https://tools-dev-ui.canvas-tools.app/"
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming pattern differs from the production environment. The prod URL uses "tools-ui" while beta uses "tools-dev-ui". Looking at the AccountTypeMappings (lines 100-102), the non-prod pattern consistently uses "-dev" suffix (e.g., "lti-dev", "proxy-dev", "tools-dev"). However, the beta URL adds "-dev" between "tools" and "ui" instead of using a consistent prefix or suffix pattern. Consider whether "tools-dev-ui" is the intended pattern or if it should be "tools-ui-dev" to better align with other naming conventions.

Suggested change
"uiFrontendUrl": "https://tools-dev-ui.canvas-tools.app/"
"uiFrontendUrl": "https://tools-ui-dev.canvas-tools.app/"

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The beta URL ends with a trailing slash, but other URLs in the same configuration (lines 116-118) do not have trailing slashes. This inconsistency could lead to issues with URL matching or CORS configuration. Consider removing the trailing slash to align with the existing URL patterns in the file.

Suggested change
"uiFrontendUrl": "https://tools-dev-ui.canvas-tools.app/"
"uiFrontendUrl": "https://tools-dev-ui.canvas-tools.app"

Copilot uses AI. Check for mistakes.

Conditions:
isProd: {"Fn::Equals": [!Ref envType, "prod"]}
Expand Down