Skip to content

Fix double error toasts#3167

Merged
david-crespo merged 1 commit intomainfrom
fix-double-toasts
Apr 3, 2026
Merged

Fix double error toasts#3167
david-crespo merged 1 commit intomainfrom
fix-double-toasts

Conversation

@david-crespo
Copy link
Copy Markdown
Collaborator

All of these mutations get confirmed and therefore have their error toasts handled by the catch in ConfirmActionModal. Using an onError means they get two toasts. Thanks @jordanhendricks for reporting this.

try {
await doAction()
} catch (error) {
addToast({
variant: 'error',
title: errorTitle,
content: (error as ApiError).message,
})
}

I am working on some zany schemes for avoiding this in the future, but in the meantime let's at least fix these.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
console Ready Ready Preview Apr 3, 2026 3:09am

Request Review

@david-crespo david-crespo changed the title Fix double toasts Fix double error toasts Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant