Skip to content

Fix double error toasts #3167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 1 commit into from
Apr 3, 2026
Merged

Fix double error toasts #3167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions app/pages/project/floating-ips/FloatingIpsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,6 @@ export default function FloatingIpsPage() {
// prettier-ignore
addToast(<>Floating IP <HL>{floatingIp.name}</HL> detached</>)
},
onError: (err) => {
addToast({ title: 'Error', content: err.message, variant: 'error' })
},
})
const { mutateAsync: deleteFloatingIp } = useApiMutation(api.floatingIpDelete, {
onSuccess(_data, variables) {
Expand Down
6 changes: 0 additions & 6 deletions app/pages/project/instances/NetworkingTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,9 +479,6 @@ export default function NetworkingTab() {
queryClient.invalidateEndpoint('instanceExternalIpList')
addToast({ content: 'Ephemeral IP detached' })
},
onError: (err) => {
addToast({ title: 'Error', content: err.message, variant: 'error' })
},
})

const { mutateAsync: floatingIpDetach } = useApiMutation(api.floatingIpDetach, {
Expand All @@ -491,9 +488,6 @@ export default function NetworkingTab() {
// prettier-ignore
addToast(<>Floating IP <HL>{variables.path.floatingIp}</HL> detached</>)
},
onError: (err) => {
addToast({ title: 'Error', content: err.message, variant: 'error' })
},
})

const { mutateAsync: externalSubnetDetach } = useApiMutation(api.externalSubnetDetach, {
Expand Down
3 changes: 0 additions & 3 deletions app/pages/project/instances/StorageTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,6 @@ export default function StorageTab() {
// prettier-ignore
addToast(<>Disk <HL>{disk.name}</HL> detached</>)
},
onError(err) {
addToast({ title: 'Failed to detach disk', content: err.message, variant: 'error' })
},
})
const { mutate: createSnapshot } = useApiMutation(api.snapshotCreate, {
onSuccess(snapshot) {
Expand Down
8 changes: 1 addition & 7 deletions app/pages/project/instances/actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,20 +63,14 @@ export const useMakeInstanceActions = (
startInstanceAsync(instanceParams, {
// prettier-ignore
onSuccess: () => addToast(<>Starting instance <HL>{instance.name}</HL></>),
onError: (error) =>
addToast({
variant: 'error',
title: `Error starting instance '${instance.name}'`,
content: error.message,
}),
}),
modalTitle: 'Confirm start instance',
modalContent: (
<p>
Are you sure you want to start <HL>{instance.name}</HL>?
</p>
),
errorTitle: `Error starting ${instance.name}`,
errorTitle: `Error starting instance '${instance.name}'`,
})
},
disabled: !instanceCan.start(instance) && (
Expand Down
Loading