Move config server CLI to panoptes-utils config; polish Typer CLI; add tests#337
Closed
Move config server CLI to panoptes-utils config; polish Typer CLI; add tests#337
panoptes-utils config; polish Typer CLI; add tests#337Conversation
Co-authored-by: wtgee <70736+wtgee@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Move config server cli to panoptes-utils namespace
Move config server CLI into panoptes-utils CLI namespace (Click → Typer)
Mar 16, 2026
Co-authored-by: wtgee <70736+wtgee@users.noreply.github.com>
Copilot
AI
changed the title
Move config server CLI into panoptes-utils CLI namespace (Click → Typer)
Migrate config server CLI to Mar 16, 2026
panoptes-utils config; switch all CLI output to rich
Contributor
There was a problem hiding this comment.
Pull request overview
Consolidates the standalone config server CLI into the existing panoptes-utils Typer CLI under a new config subcommand, and standardizes CLI output to use Rich across modules.
Changes:
- Adds a new Typer-based config CLI (
run,stop,get,set) underpanoptes-utils config. - Wires the new
configsub-app into the main CLI entry point. - Removes the legacy
panoptes-config-serverconsole script entry point and updates tests/changelog accordingly.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/panoptes/utils/cli/config.py |
New Typer sub-app implementing config server commands and Rich-based output. |
src/panoptes/utils/cli/main.py |
Registers the new config subcommand and enables Rich markup / no-args help. |
src/panoptes/utils/cli/image.py |
Switches CLI output to Rich and enables Rich markup / no-args help. |
tests/config/test_config_cli.py |
Updates CLI tests to invoke the consolidated panoptes-utils app. |
pyproject.toml |
Removes the panoptes-config-server entry point. |
CHANGELOG.md |
Documents CLI consolidation and script removal. |
Comments suppressed due to low confidence (1)
tests/config/test_config_cli.py:32
--portis defined on theconfigapp callback (group-level option), but this test passes it after therunsubcommand. With Click/Typer parsing, group options must appear before the subcommand (e.g.,config --port ... run ...), otherwise the invocation will fail with an unknown option.
"run",
"--config-file",
f"{config_path}",
"--port",
cli_config_port,
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: wtgee <70736+wtgee@users.noreply.github.com>
Copilot
AI
changed the title
Migrate config server CLI to
Switch all Typer CLI scripts to rich output; add rich as explicit dependency
Mar 16, 2026
panoptes-utils config; switch all CLI output to rich
Copilot
AI
changed the title
Switch all Typer CLI scripts to rich output; add rich as explicit dependency
Harmonizing config server cli with panoptes-utils
Mar 17, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #337 +/- ##
===========================================
- Coverage 83.76% 81.68% -2.08%
===========================================
Files 21 23 +2
Lines 1355 1398 +43
===========================================
+ Hits 1135 1142 +7
- Misses 220 256 +36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: wtgee <70736+wtgee@users.noreply.github.com>
Copilot
AI
changed the title
Harmonizing config server cli with panoptes-utils
Harmonizing config server CLI with panoptes-utils
Mar 17, 2026
… unused imports) Co-authored-by: wtgee <70736+wtgee@users.noreply.github.com>
Copilot
AI
changed the title
Harmonizing config server CLI with panoptes-utils
Add comprehensive CLI test coverage for config and image subcommands
Mar 17, 2026
Copilot
AI
changed the title
Add comprehensive CLI test coverage for config and image subcommands
Fix ruff linting errors in test_image_cli.py
Mar 17, 2026
Copilot
AI
changed the title
Fix ruff linting errors in test_image_cli.py
Move config server CLI into Mar 17, 2026
panoptes-utils config subcommand
…e patch Co-authored-by: wtgee <70736+wtgee@users.noreply.github.com>
Copilot
AI
changed the title
Move config server CLI into
Fix test hang caused by global Mar 17, 2026
panoptes-utils config subcommandtime.sleep patch leaking across tests under coverage
Copilot
AI
changed the title
Fix test hang caused by global
Fix test suite hang caused by leaking Mar 17, 2026
time.sleep patch leaking across tests under coveragetime.sleep mock under coverage
Co-authored-by: wtgee <70736+wtgee@users.noreply.github.com>
Copilot
AI
changed the title
Fix test suite hang caused by leaking
Move config server CLI to Mar 17, 2026
time.sleep mock under coveragepanoptes-utils config; polish Typer CLI; add tests
Copilot stopped work on behalf of
wtgee due to an error
March 17, 2026 19:20
Member
|
Replaced by #340 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
panoptes-config-serverentry point was a separate CLI inconsistent with the unifiedpanoptes-utilsCLI. This PR consolidates it and improves CLI polish across the board.Changes
panoptes-utils configsubcommand (src/panoptes/utils/cli/config.py): Typer-basedrun,stop,get,setcommands. Replaces the oldpanoptes-config-serverentry point. Includes host0.0.0.0→localhostnormalisation and a startup wait-loop (--startup-timeout, default 30 s).image.py,main.py):typer.secho→rich.printwith markup;rich_markup_mode="rich"andno_args_is_help=Trueon allTyper()instances.rich>=12.3.0added as explicit core dependency (was already transitive viatyper).configCLI (run,stop,get,set, host normalisation, startup timeout, monitor exception) andimageCLI (cr2 to-jpg,cr2 to-fits,fits solve).patch("panoptes.utils.cli.config.time.sleep")patches the globaltime.sleepand leaks underpytest-cov. Fixed by patching the module-level reference instead:Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/graphql/usr/bin/gh gh auth status(http block)/usr/bin/gh gh pr view 337 --repo panoptes/panoptes-utils --json title,body(http block)If you need me to access, download, or install something from one of these locations, you can either:
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.