Fix: Use order-independent tag comparison in tag wizard#30
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Use sort-and-join comparison to handle both reordering and duplicates correctly. Closes #22
FL4TLiN3
force-pushed
the
fix/tag-comparison-order-independent
branch
from
ce24063 to
fc59fcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
includes()instead of index-based comparison["foo", "bar"]and["bar", "foo"]are now considered equalTest plan
Closes #22
Note
Make tag comparison order-independent in the confirm step to avoid treating tag reordering as a change.
packages/tui/apps/tag/app.tsx)Written by Cursor Bugbot for commit fc59fcd. This will update automatically on new commits. Configure here.