Revert "Fix: Use order-independent tag comparison in tag wizard"#38
Closed
Revert "Fix: Use order-independent tag comparison in tag wizard"#38
Conversation
This reverts commit 166f4a5.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| const tagsChanged = | ||
| tags.length !== customCurrentTags.length || | ||
| [...tags].sort().join(",") !== [...customCurrentTags].sort().join(",") | ||
| tags.length !== customCurrentTags.length || tags.some((t, i) => t !== customCurrentTags[i]) |
There was a problem hiding this comment.
Bug: Order-dependent tag comparison gives false change detection
The tagsChanged comparison uses positional index matching (tags.some((t, i) => t !== customCurrentTags[i])), which detects tags as "changed" when they contain the same values but in different order. Since tags are semantically a set where order is irrelevant, this causes false positives in the confirmation UI—showing tags as changed when the user simply typed them in a different order than they were stored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #30
Note
Make tag change detection in
ConfirmSteporder-sensitive by comparing tags by index instead of using order-independent sorting.Written by Cursor Bugbot for commit fb97d8d. This will update automatically on new commits. Configure here.