Skip to content

Revert "Fix: Use order-independent tag comparison in tag wizard" #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FL4TLiN3 wants to merge 1 commit into from
Closed

Revert "Fix: Use order-independent tag comparison in tag wizard" #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/tui/apps/tag/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,7 @@ function ConfirmStep({
})
const customCurrentTags = currentTags.filter((t) => t !== "latest")
const tagsChanged =
tags.length !== customCurrentTags.length ||
[...tags].sort().join(",") !== [...customCurrentTags].sort().join(",")
tags.length !== customCurrentTags.length || tags.some((t, i) => t !== customCurrentTags[i])
Copy link

@cursor cursor bot Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Order-dependent tag comparison gives false change detection

The tagsChanged comparison uses positional index matching (tags.some((t, i) => t !== customCurrentTags[i])), which detects tags as "changed" when they contain the same values but in different order. Since tags are semantically a set where order is irrelevant, this causes false positives in the confirmation UI—showing tags as changed when the user simply typed them in a different order than they were stored.

Fix in Cursor Fix in Web

return (
<Box flexDirection="column">
<Text bold>Confirm update for {expertKey}:</Text>
Expand Down
Loading