-
Notifications
You must be signed in to change notification settings - Fork 10
fix: Add python 3.13 support #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi @FriedGil , thank you for the contribution! This would be a nice change! 🚀 It looks like the CICD is currently failing, unrelated to the changes you made. Could you try change the |
|
Yes. The tests passed locally but clearly something is awry. I'll do that and take another look. |
I believe this should address (or at the very least change) the current errors.
|
Hi @FriedGil , I suspect you'll need to remove some of the upper bounds in the |
|
I see. Is there a way for me to replicate the workflow locally so that you don't have to approve it each time? |
|
Good question! It's because you're a first-time contributor. I've relaxed the rules for the time being, such that my approval should no longer be needed as long as you're not a new user on Github. I can't disable it altogether. |
|
I've looked into it further and fastpdb does not have have a working conda package for python 3.13 (it only has a python wheel). A PR was made to change this but failed checks and has not been resolved in almost a year: conda-forge/fastpdb-feedstock#3 |
Addresses #301
Changelogs