Skip to content

Conversation

@FriedGil
Copy link

@FriedGil FriedGil commented Sep 17, 2025

Addresses #301

Changelogs

  • Updated all version specifications to include 3.13
  • Bumped pyarrow dependency to >=21.0.0 for 3.13 compatibility
  • Verified all tests pass on Python 3.13

@FriedGil FriedGil requested a review from cwognum as a code owner September 17, 2025 03:45
@cwognum
Copy link
Collaborator

cwognum commented Sep 17, 2025

Hi @FriedGil , thank you for the contribution! This would be a nice change! 🚀

It looks like the CICD is currently failing, unrelated to the changes you made. Could you try change the 0.0.0.dev1 to 0.0.0 in the pyproject.toml?

[tool.setuptools_scm]
fallback_version = "0.0.0"

@FriedGil
Copy link
Author

Yes. The tests passed locally but clearly something is awry. I'll do that and take another look.

@FriedGil FriedGil marked this pull request as draft September 17, 2025 16:04
I believe this should address (or at the very least change) the current errors.
@cwognum
Copy link
Collaborator

cwognum commented Sep 17, 2025

Hi @FriedGil , I suspect you'll need to remove some of the upper bounds in the env.yml, same as you did for the pyproject.toml.

@FriedGil
Copy link
Author

I see. Is there a way for me to replicate the workflow locally so that you don't have to approve it each time?

@cwognum
Copy link
Collaborator

cwognum commented Sep 17, 2025

Good question! It's because you're a first-time contributor. I've relaxed the rules for the time being, such that my approval should no longer be needed as long as you're not a new user on Github. I can't disable it altogether.

@FriedGil
Copy link
Author

FriedGil commented Sep 17, 2025

I've looked into it further and fastpdb does not have have a working conda package for python 3.13 (it only has a python wheel).

A PR was made to change this but failed checks and has not been resolved in almost a year: conda-forge/fastpdb-feedstock#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants