test: add regression tests for multi-context basename resolution#737
Closed
test: add regression tests for multi-context basename resolution#737
Conversation
Adds tests verifying _detect_modules_from_branch_diff preserves directory context for prompts in context-specific directories like prompts/frontend/ and prompts/backend/. Also covers extension prompts under extensions/github_pdd_app/prompts/. These basenames (e.g. "frontend/app/dashboard/page") must retain their directory prefix so pdd sync resolves the correct .pddrc context. Related: promptdriven/pdd_cloud#826 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds regression coverage for _detect_modules_from_branch_diff to ensure prompt module basenames preserve directory context (multi-context repos) and correctly handle nested prompts/ directories under extensions.
Changes:
- Add a regression test asserting context-prefixed basenames are preserved for prompts under
prompts/<context>/.... - Add a regression test asserting extension prompt paths like
extensions/<ext>/prompts/...are handled and produce correct basenames.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Moving to gltanaka/pdd — this should be in the private fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_detect_modules_from_branch_diffverifying it preserves directory context for prompts in context-specific directories (e.g.prompts/frontend/,prompts/backend/)extensions/github_pdd_app/prompts/The code already handles this correctly — these tests prevent future regressions.
Related: promptdriven/pdd_cloud#826
Test plan
TestDetectModulesFromBranchDifftests still pass🤖 Generated with Claude Code