Skip to content

[ET-VK][ez] Use tree reduction in q8ta_linear_gemv shader#17792

Merged
meta-codesync[bot] merged 1 commit intogh/SS-JIA/453/basefrom
gh/SS-JIA/453/head
Mar 3, 2026
Merged

[ET-VK][ez] Use tree reduction in q8ta_linear_gemv shader#17792
meta-codesync[bot] merged 1 commit intogh/SS-JIA/453/basefrom
gh/SS-JIA/453/head

Conversation

@SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Mar 2, 2026

Stack from ghstack (oldest at bottom):

Replace the serial O(WGS) reduction loop with a tree reduction pattern
(O(log2(WGS))). Previously, only thread 0 summed all 64 partial
accumulators sequentially. Now all threads participate in a classic
halving reduction, matching the pattern already used in
linear_q4gsw_coop.glsl.

Authored by Claude.

Differential Revision: D94949137

Replace the serial O(WGS) reduction loop with a tree reduction pattern
(O(log2(WGS))). Previously, only thread 0 summed all 64 partial
accumulators sequentially. Now all threads participate in a classic
halving reduction, matching the pattern already used in
linear_q4gsw_coop.glsl.

Authored by Claude.

Differential Revision: [D94949137](https://our.internmc.facebook.com/intern/diff/D94949137/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 2, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17792

Note: Links to docs will display an error until the docs builds have been completed.

❌ 15 New Failures, 1 Cancelled Job, 2 Unrelated Failures

As of commit a1e2aa2 with merge base ae41854 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync bot merged commit ad8ff12 into gh/SS-JIA/453/base Mar 3, 2026
189 of 216 checks passed
@meta-codesync meta-codesync bot deleted the gh/SS-JIA/453/head branch March 3, 2026 08:28
@meta-codesync meta-codesync bot temporarily deployed to cherry-pick-bot March 3, 2026 08:28 Inactive
SS-JIA pushed a commit that referenced this pull request Mar 3, 2026
Replace the serial O(WGS) reduction loop with a tree reduction pattern
(O(log2(WGS))). Previously, only thread 0 summed all 64 partial
accumulators sequentially. Now all threads participate in a classic
halving reduction, matching the pattern already used in
linear_q4gsw_coop.glsl.

Authored by Claude.

Differential Revision: [D94949137](https://our.internmc.facebook.com/intern/diff/D94949137/)

ghstack-source-id: 346524552
Pull Request resolved: #17792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants