[ET-VK][testing] Add GPU device name override for on-device model tests#17795
[ET-VK][testing] Add GPU device name override for on-device model tests#17795meta-codesync[bot] merged 1 commit intogh/SS-JIA/456/basefrom
Conversation
Add the ability to override the Vulkan device name at runtime so that device-adaptive code paths (e.g. memory layout selection) can be tested on hardware that doesn't match the overridden device type. PhysicalDevice::override_device_name() and Adapter::override_device_name() are added behind VULKAN_DEBUG. The device type detection logic is refactored into a reusable determine_device_type() helper to avoid duplication between the constructor and the override function. All test binaries in fb/test/models/ (classification, greenscreen, scenex, skin_seg) now accept --gpu_name to invoke the override before loading the model. The Skycastle CI workflows are updated to re-run classification and greenscreen tests with --gpu_name Mali-G715 in addition to the default run. Differential Revision: [D94949136](https://our.internmc.facebook.com/intern/diff/D94949136/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17795
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 2 Unrelated FailuresAs of commit 63832a3 with merge base ae41854 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Add the ability to override the Vulkan device name at runtime so that device-adaptive code paths (e.g. memory layout selection) can be tested on hardware that doesn't match the overridden device type. PhysicalDevice::override_device_name() and Adapter::override_device_name() are added behind VULKAN_DEBUG. The device type detection logic is refactored into a reusable determine_device_type() helper to avoid duplication between the constructor and the override function. All test binaries in fb/test/models/ (classification, greenscreen, scenex, skin_seg) now accept --gpu_name to invoke the override before loading the model. The Skycastle CI workflows are updated to re-run classification and greenscreen tests with --gpu_name Mali-G715 in addition to the default run. Differential Revision: [D94949136](https://our.internmc.facebook.com/intern/diff/D94949136/) ghstack-source-id: 346525920 Pull Request resolved: #17795
This PR needs a
|
c75bf94
into
gh/SS-JIA/456/base
Add the ability to override the Vulkan device name at runtime so that device-adaptive code paths (e.g. memory layout selection) can be tested on hardware that doesn't match the overridden device type. PhysicalDevice::override_device_name() and Adapter::override_device_name() are added behind VULKAN_DEBUG. The device type detection logic is refactored into a reusable determine_device_type() helper to avoid duplication between the constructor and the override function. All test binaries in fb/test/models/ (classification, greenscreen, scenex, skin_seg) now accept --gpu_name to invoke the override before loading the model. The Skycastle CI workflows are updated to re-run classification and greenscreen tests with --gpu_name Mali-G715 in addition to the default run. Differential Revision: [D94949136](https://our.internmc.facebook.com/intern/diff/D94949136/) ghstack-source-id: 346525920 Pull Request resolved: #17795
Add the ability to override the Vulkan device name at runtime so that device-adaptive code paths (e.g. memory layout selection) can be tested on hardware that doesn't match the overridden device type. PhysicalDevice::override_device_name() and Adapter::override_device_name() are added behind VULKAN_DEBUG. The device type detection logic is refactored into a reusable determine_device_type() helper to avoid duplication between the constructor and the override function. All test binaries in fb/test/models/ (classification, greenscreen, scenex, skin_seg) now accept --gpu_name to invoke the override before loading the model. The Skycastle CI workflows are updated to re-run classification and greenscreen tests with --gpu_name Mali-G715 in addition to the default run. Differential Revision: [D94949136](https://our.internmc.facebook.com/intern/diff/D94949136/) ghstack-source-id: 346525920 Pull Request resolved: #17795
Add the ability to override the Vulkan device name at runtime so that device-adaptive code paths (e.g. memory layout selection) can be tested on hardware that doesn't match the overridden device type. PhysicalDevice::override_device_name() and Adapter::override_device_name() are added behind VULKAN_DEBUG. The device type detection logic is refactored into a reusable determine_device_type() helper to avoid duplication between the constructor and the override function. All test binaries in fb/test/models/ (classification, greenscreen, scenex, skin_seg) now accept --gpu_name to invoke the override before loading the model. The Skycastle CI workflows are updated to re-run classification and greenscreen tests with --gpu_name Mali-G715 in addition to the default run. Differential Revision: [D94949136](https://our.internmc.facebook.com/intern/diff/D94949136/) ghstack-source-id: 346525920 Pull Request resolved: #17795
Add the ability to override the Vulkan device name at runtime so that device-adaptive code paths (e.g. memory layout selection) can be tested on hardware that doesn't match the overridden device type. PhysicalDevice::override_device_name() and Adapter::override_device_name() are added behind VULKAN_DEBUG. The device type detection logic is refactored into a reusable determine_device_type() helper to avoid duplication between the constructor and the override function. All test binaries in fb/test/models/ (classification, greenscreen, scenex, skin_seg) now accept --gpu_name to invoke the override before loading the model. The Skycastle CI workflows are updated to re-run classification and greenscreen tests with --gpu_name Mali-G715 in addition to the default run. Differential Revision: [D94949136](https://our.internmc.facebook.com/intern/diff/D94949136/) ghstack-source-id: 346525920 Pull Request resolved: #17795
Stack from ghstack (oldest at bottom):
Add the ability to override the Vulkan device name at runtime so that
device-adaptive code paths (e.g. memory layout selection) can be tested
on hardware that doesn't match the overridden device type.
PhysicalDevice::override_device_name() and Adapter::override_device_name()
are added behind VULKAN_DEBUG. The device type detection logic is refactored
into a reusable determine_device_type() helper to avoid duplication between
the constructor and the override function.
All test binaries in fb/test/models/ (classification, greenscreen, scenex,
skin_seg) now accept --gpu_name to invoke the override before loading the
model. The Skycastle CI workflows are updated to re-run classification and
greenscreen tests with --gpu_name Mali-G715 in addition to the default run.
Differential Revision: D94949136