feat(monitor-server): add direct Beckhoff ADS client#114
Merged
q-soriarty merged 2 commits intodevelopfrom Feb 14, 2026
Merged
Conversation
Add PlcAdsState enum, PlcStateDto, AdsConnectionInfo, and AdsVariableSubscription to FlowForge.Shared for use across monitor and build server without requiring Beckhoff NuGet dependencies. Update PlcTargetDto with CurrentState and DeployRequestDto with AdsPort. Create doc/ADS_INTEGRATION.md documenting the decision to use direct Beckhoff.TwinCAT.Ads instead of custom MQTT ADS relay topics. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace IMqttAdsClient/MqttAdsClient with IAdsClient/AdsClientWrapper using Beckhoff.TwinCAT.Ads + TcpRouter for direct ADS-over-TCP from Linux Docker containers. Add batch read (Sum Commands), PLC state read, and ADS notification subscription to the interface. Update PlcDataHub to use IAdsClient with SubscriptionManager. Add ADS connection config (TargetHostname, AdsPort, AdsTcpPort) to MonitorOptions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Beckhoff.TwinCAT.Ads+Beckhoff.TwinCAT.Ads.TcpRouterNuGet packagesIAdsClientinterface replacingIMqttAdsClientwith direct ADS methods (connect, read, batch read via Sum Commands, subscribe via ADS notifications, state read)AdsClientWrapperstub implementation wrappingAdsClient+TcpRouterIMqttAdsClientandMqttAdsClient(MQTT relay no longer needed)MonitorOptionswith ADS-direct config (TargetHostname,AdsPort,AdsTcpPort)PlcDataHubto useIAdsClientfor subscribe/unsubscribeAdsClientWrapperTestsDependencies
feature/ads-shared-types)Test plan
dotnet build src/monitor-server/FlowForge.MonitorServer.slncompilesdotnet testpasses (existing + new placeholder tests)🤖 Generated with Claude Code