Fixes various issues including flickering nav items, and smint-disabled items highlighting#13
Open
ateich wants to merge 7 commits intorabmyself:masterfrom
Open
Fixes various issues including flickering nav items, and smint-disabled items highlighting#13ateich wants to merge 7 commits intorabmyself:masterfrom
ateich wants to merge 7 commits intorabmyself:masterfrom
Conversation
Resolved issue where last nav item and second to last nav item would quickly alternate being active when scrolling past the bottom of screen by changing the window position check to be >= window height instead of ==
Resolved issue where last nav item and second to last nav item would quickly alternate being active when scrolling past the bottom of screen by changing the window position check to be >= window height instead of ==
Fixed issue where if a nav item of class smint-disable was the last nav item, it would become active (highlighted) when the user scrolled to the bottom of the window. $smintItems no longer includes items of class smint-disable. (line 20)
Fixed issue where if a nav item of class smint-disable was the last nav item, it would become active (highlighted) when the user scrolled to the bottom of the window. $smintItems no longer includes items of class smint-disable. (line 20)
Resolved "Uncaught TypeError: Cannot read property 'id' of undefined" with a check for null value of optionLocs[index+1] on line 67.
Deleted jquery.smint.js, which has errors, from main folder as there is a different jquery.smint.js in the demo folder which has no errors.
Will now check if classes contain smint-disable, as opposed to if the class is exactly "smint-disable"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed:
• Nav items flickering when scrolling past the bottom of the window
• Nav items of class smint-disable highlighting while scrolling despite not being a section of the page
• Uncaught Type Error thrown while scrolling
Also removed the jquery.smint.js from the main folder as it was not an exact duplicate of the jquery.smint.js in the demo/js folder. The main folder js file contained errors, while the demo js file works properly.