Skip to content

Fixes various issues including flickering nav items, and smint-disabled items highlighting #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ateich wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fixes various issues including flickering nav items, and smint-disabled items highlighting #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
257d1f8
Update jquery.smint.js
ateich Feb 28, 2014
4ac5698
Fix for nav items flickering when scrolling past bottom of window
ateich Feb 28, 2014
77c15cc
fixed smint-disable itmes from highlighting
ateich Feb 28, 2014
ca0023c
fixed smint-disable items from highlighting
ateich Feb 28, 2014
08bccd7
Added catch for uncaught Type Error
ateich Feb 28, 2014
c187472
Delete jquery.smint.js from main folder
ateich Feb 28, 2014
2f91eed
Allow smint-disable to have other classes
ateich Feb 28, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions demo/js/jquery.smint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ If you like Smint, or have suggestions on how it could be improved, send me a tw
$.fn.smint = function( options ) {

var $smint = this,
$smintItems = $smint.find('a'),
$smintItems = $smint.find('a:not([class*="smint-disable"])'),
$window = $(window),
settings = $.extend({}, $.fn.smint.defaults, options),
// Set the variables needed
Expand Down Expand Up @@ -64,10 +64,13 @@ If you like Smint, or have suggestions on how it could be improved, send me a tw
if(optionLocs[index].top <= scrollTop && scrollTop <= optionLocs[index].bottom){
$smintItems.removeClass("active");
$("#"+id).addClass("active");
if(!scrollingDown){
$("#"+optionLocs[index+1].id).removeClass("active");
} else if(index > 0) {
$("#"+optionLocs[index-1].id).removeClass("active");
if(optionLocs[index+1])
{
if(!scrollingDown){
$("#"+optionLocs[index+1].id).removeClass("active");
} else if(index > 0) {
$("#"+optionLocs[index-1].id).removeClass("active");
}
}
}
};
Expand All @@ -84,7 +87,12 @@ If you like Smint, or have suggestions on how it could be improved, send me a tw
// Check if at bottom of page, if so, add class to last <a> as sometimes the last div
// isnt long enough to scroll to the top of the page and trigger the active state.

if($window.scrollTop() + $window.height() == $(document).height()) {
/* Using >= instead of == prevents last item from being
* un-highlighted when the window bounces back in browser
*
* -Andrew Teich
*/
if($window.scrollTop() + $window.height() >= $(document).height()) {
$smintItems.removeClass('active');
$smintItems.last().addClass('active');
}
Expand Down
152 changes: 0 additions & 152 deletions jquery.smint.js
View file
Open in desktop

This file was deleted.