Skip to content

feat(common-popup-with-origin): extract common code of tooltip, popover and hover card #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(common-popup-with-origin): extract common code of tooltip, popover and hover card #241

wants to merge 1 commit into from

Conversation

@pawel-twardziak
Copy link
Contributor

@pawel-twardziak pawel-twardziak commented Dec 30, 2024

Closes #236

@pawel-twardziak pawel-twardziak linked an issue Dec 30, 2024 that may be closed by this pull request
[Primitives] Extract common code of tooltip, popover and hover card #236
Open
@pawel-twardziak pawel-twardziak self-assigned this Dec 30, 2024
@vercel
Copy link

vercel bot commented Dec 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocks-showcase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 4:25pm
primitives ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 4:25pm
radix-astro-doc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 4:25pm
shadcn-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 4:25pm
taxonomy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 4:25pm

@pawel-twardziak pawel-twardziak mentioned this pull request Jan 1, 2025
Closed
@pawel-twardziak
Copy link
Contributor Author

pawel-twardziak commented Jan 5, 2025

@pimenovoleg hi, I am having a break from my computer. I will work back on the repo next weekend.

@pimenovoleg
Copy link
Contributor

pimenovoleg commented Jan 6, 2025

@pimenovoleg hi, I am having a break from my computer. I will work back on the repo next weekend.

No worries, wishing you success in restoring everything!

@pawel-twardziak
Copy link
Contributor Author

pawel-twardziak commented Jan 13, 2025

@pimenovoleg I am working back on it. But it is time for skiing :) I will be continuing next week.

@pimenovoleg
Copy link
Contributor

pimenovoleg commented Jan 14, 2025

@pimenovoleg I am working back on it. But it is time for skiing :) I will be continuing next week.

Good news, I really appreciate your contribution! 👍
Check out (sometimes) Discord, I try to share updates there.

@pimenovoleg
Copy link
Contributor

pimenovoleg commented Feb 5, 2025

@pawel-twardziak How are you feeling? Ready to refine the PR?

@pawel-twardziak
Copy link
Contributor Author

pawel-twardziak commented Feb 5, 2025 •
edited
Loading

@pimenovoleg I have already recovered, thanks. I can work back on it but there is one small problem - I am going for skiing again 😄 And will be back on it after 18th of February. Ok?

@pimenovoleg
Copy link
Contributor

pimenovoleg commented Mar 23, 2025

@pimenovoleg I have already recovered, thanks. I can work back on it but there is one small problem - I am going for skiing again 😄 And will be back on it after 18th of February. Ok?

Is it possible to join in on improving this PR? :)

@pawel-twardziak
Copy link
Contributor Author

pawel-twardziak commented Mar 23, 2025

@pimenovoleg Hi :) yes, sure, I'll work back on it. But I've been quite busy lately, so it might take 2-3 weeks. Ok? :)

@pimenovoleg
Copy link
Contributor

pimenovoleg commented Mar 23, 2025

@pimenovoleg Hi :) yes, sure, I'll work back on it. But I've been quite busy lately, so it might take 2-3 weeks. Ok? :)

Okey ;)

@pimenovoleg
Copy link
Contributor

pimenovoleg commented May 4, 2025

@pawel-twardziak
What are your plans for this PR? 🛠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pimenovoleg pimenovoleg Awaiting requested review from pimenovoleg pimenovoleg will be requested when the pull request is marked ready for review pimenovoleg is a code owner

@artembelik artembelik Awaiting requested review from artembelik artembelik will be requested when the pull request is marked ready for review artembelik is a code owner

Assignees

@pawel-twardziak pawel-twardziak

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Primitives] Extract common code of tooltip, popover and hover card

3 participants

@pawel-twardziak @pimenovoleg