feat(tooltip): tooltip follow the trigger/anchor

[pawel-twardziak]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
blocks-showcase	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 31, 2024 4:58pm
primitives	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 31, 2024 4:58pm
radix-astro-doc	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 31, 2024 4:58pm
shadcn-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 31, 2024 4:58pm
taxonomy	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 31, 2024 4:58pm

[pimenovoleg]

This is an interesting solution!

I think we should consider providing an out-of-the-box approach so that using the component doesn't require adding extra logic.

For example, here:
https://github.com/Rikarin/xui/blob/master/libs/xui/src/tooltip/tooltip.directive.ts#L34
https://github.com/angular/components/blob/main/src/material/tooltip/tooltip.ts#L460

By using ComponentPortal, we achieve a behavior where the tooltip follows the trigger.

This approach could simplify usage and improve the developer experience. What do you think?

[pawel-twardziak]

This is an interesting solution!

I think we should consider providing an out-of-the-box approach so that using the component doesn't require adding extra logic.

For example, here: https://github.com/Rikarin/xui/blob/master/libs/xui/src/tooltip/tooltip.directive.ts#L34 https://github.com/angular/components/blob/main/src/material/tooltip/tooltip.ts#L460

By using ComponentPortal, we achieve a behavior where the tooltip follows the trigger.

This approach could simplify usage and improve the developer experience. What do you think?

yes @pimenovoleg great point! That coould be a good way, I will try the portal as I've never done it befre :)

[pawel-twardziak]

@pimenovoleg can we go with this simple solution so far? I've investigated a bit the portal and I might need to apply a small redesing to tooltip , popover and hover-card. But that would be easier for me if I had the common parts extracted following that #241 - so that I can aplly to and test all of the pop-ups we have.

Thus my proposal is:

• let's merge this solution (quite simple one) or let's just abandon it
• I will finish that feat(common-popup-with-origin): extract common code of tooltip, popover and hover card #241 up
• I will apply the portal to the common stuff

[pimenovoleg]

@pimenovoleg can we go with this simple solution so far? I've investigated a bit the portal and I might need to apply a small redesing to tooltip , popover and hover-card. But that would be easier for me if I had the common parts extracted following that #241 - so that I can aplly to and test all of the pop-ups we have.

Thus my proposal is:

• let's merge this solution (quite simple one) or let's just abandon it
• I will finish that feat(common-popup-with-origin): extract common code of tooltip, popover and hover card #241 up
• I will apply the portal to the common stuff

Great to see you've figured out Portal! In that case, I think it's better not to confuse users and postpone this PR.

Let's implement it right (better) away using Portal. 👍

[pawel-twardziak]

Great :) so let's keep the issue #243 open, I will work back on than soon and now I am closing this PR without merging @pimenovoleg 👍

[pawel-twardziak]

Closed with no merge - Portal will be implemented as a solution for #243 on another branch