Skip to content

feat(tooltip): tooltip follow the trigger/anchor #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pawel-twardziak wants to merge 9 commits into from
Closed

feat(tooltip): tooltip follow the trigger/anchor #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4c16a24
feat(popover): expose update-position method
pawel-twardziak Dec 31, 2024
cdb9ab2
feat(hover-card): expose update-position method
pawel-twardziak Dec 31, 2024
5ab45d1
feat(tooltip): expose update-position method
pawel-twardziak Dec 31, 2024
0871ab0
chore(tooltip): make story tooltip content dynamic
pawel-twardziak Dec 31, 2024
dd01eec
chore(tooltip): add move trigger story
pawel-twardziak Dec 31, 2024
f79bd5f
chore(tooltip): make word bank of 100 words
pawel-twardziak Dec 31, 2024
337876d
chore(tooltip): add are-elements-overlaping util
pawel-twardziak Dec 31, 2024
585698d
chore(tooltip): add move anchor story
pawel-twardziak Dec 31, 2024
a39fc33
Merge branch 'main' into feature/tooltip/243-should-follow-the-trigger
pawel-twardziak Dec 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/primitives/hover-card/src/hover-card-anchor.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export class RdxHoverCardAnchorDirective {
* */
protected rootDirective = injectHoverCardRoot(true);
/** @ignore */
readonly elementRef = inject(ElementRef);
readonly elementRef = inject<ElementRef<HTMLElement>>(ElementRef);
/** @ignore */
readonly overlayOrigin = inject(CdkOverlayOrigin);
/** @ignore */
Expand Down
6 changes: 5 additions & 1 deletion packages/primitives/hover-card/src/hover-card-content.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,10 @@ export class RdxHoverCardContentDirective implements OnInit {
return this.connectedOverlay.positionChange.asObservable();
}

updatePosition() {
this.connectedOverlay.overlayRef?.updatePosition();
}

/** @ignore */
private connectKeydownEscape() {
this.connectedOverlay.overlayKeydown
Expand Down Expand Up @@ -277,7 +281,7 @@ export class RdxHoverCardContentDirective implements OnInit {
const prevPositions = this.connectedOverlay.positions;
this.connectedOverlay.positions = positions;
this.fireOverlayNgOnChanges('positions', this.connectedOverlay.positions, prevPositions);
this.connectedOverlay.overlayRef?.updatePosition();
this.updatePosition();
}

/** @ignore */
Expand Down
2 changes: 1 addition & 1 deletion packages/primitives/popover/src/popover-anchor.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export class RdxPopoverAnchorDirective {
* */
protected popoverRoot = injectPopoverRoot(true);
/** @ignore */
readonly elementRef = inject(ElementRef);
readonly elementRef = inject<ElementRef<HTMLElement>>(ElementRef);
/** @ignore */
readonly overlayOrigin = inject(CdkOverlayOrigin);
/** @ignore */
Expand Down
6 changes: 5 additions & 1 deletion packages/primitives/popover/src/popover-content.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,10 @@ export class RdxPopoverContentDirective implements OnInit {
return this.connectedOverlay.positionChange.asObservable();
}

updatePosition() {
this.connectedOverlay.overlayRef?.updatePosition();
}

/** @ignore */
private connectKeydownEscape() {
this.connectedOverlay.overlayKeydown
Expand Down Expand Up @@ -277,7 +281,7 @@ export class RdxPopoverContentDirective implements OnInit {
const prevPositions = this.connectedOverlay.positions;
this.connectedOverlay.positions = positions;
this.fireOverlayNgOnChanges('positions', this.connectedOverlay.positions, prevPositions);
this.connectedOverlay.overlayRef?.updatePosition();
this.updatePosition();
}

/** @ignore */
Expand Down
2 changes: 1 addition & 1 deletion packages/primitives/tooltip/src/tooltip-anchor.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export class RdxTooltipAnchorDirective {
* */
protected rootDirective = injectTooltipRoot(true);
/** @ignore */
readonly elementRef = inject(ElementRef);
readonly elementRef = inject<ElementRef<HTMLElement>>(ElementRef);
/** @ignore */
readonly overlayOrigin = inject(CdkOverlayOrigin);
/** @ignore */
Expand Down
6 changes: 5 additions & 1 deletion packages/primitives/tooltip/src/tooltip-content.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,10 @@ export class RdxTooltipContentDirective implements OnInit {
return this.connectedOverlay.positionChange.asObservable();
}

updatePosition() {
this.connectedOverlay.overlayRef?.updatePosition();
}

/** @ignore */
private connectKeydownEscape() {
this.connectedOverlay.overlayKeydown
Expand Down Expand Up @@ -277,7 +281,7 @@ export class RdxTooltipContentDirective implements OnInit {
const prevPositions = this.connectedOverlay.positions;
this.connectedOverlay.positions = positions;
this.fireOverlayNgOnChanges('positions', this.connectedOverlay.positions, prevPositions);
this.connectedOverlay.overlayRef?.updatePosition();
this.updatePosition();
}

/** @ignore */
Expand Down
1 change: 0 additions & 1 deletion packages/primitives/tooltip/src/tooltip-root.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,6 @@ export class RdxTooltipRootDirective {
.asObservable()
.pipe(
map((action) => {
console.log(action);
switch (action) {
case RdxTooltipAction.OPEN:
return { action, duration: this.openDelay() };
Expand Down
9 changes: 6 additions & 3 deletions packages/primitives/tooltip/stories/tooltip-anchor.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Component, viewChild } from '@angular/core';
import { Component, signal, viewChild } from '@angular/core';
import { FormsModule } from '@angular/forms';
import { LucideAngularModule, MapPin, MapPinPlus, MountainSnow, TriangleAlert, X } from 'lucide-angular';
import { RdxTooltipModule } from '../index';
Expand All @@ -7,6 +7,7 @@ import { RdxTooltipContentAttributesComponent } from '../src/tooltip-content-att
import { provideRdxCdkEventService } from '../src/utils/cdk-event.service';
import { containerAlert } from './utils/constants';
import { OptionPanelBase } from './utils/option-panel-base.class';
import { generateRandomSentence } from './utils/rendom-sentence.util';
import styles from './utils/styles.constants';
import { WithOptionPanelComponent } from './utils/with-option-panel.component';

Expand Down Expand Up @@ -64,7 +65,7 @@ import { WithOptionPanelComponent } from './utils/with-option-panel.component';
<button class="reset TooltipClose" rdxTooltipClose aria-label="Close">
<lucide-angular [img]="XIcon" size="12" style="display: flex" />
</button>
Add to library
{{ tooltipHtml() }}
<div
class="TooltipArrow"
[width]="arrowWidth()"
Expand Down Expand Up @@ -120,7 +121,7 @@ import { WithOptionPanelComponent } from './utils/with-option-panel.component';
<button class="reset TooltipClose" rdxTooltipClose aria-label="Close">
<lucide-angular [img]="XIcon" size="12" style="display: flex" />
</button>
Add to library
{{ tooltipHtml() }}
<div
class="TooltipArrow"
[width]="arrowWidth()"
Expand All @@ -136,6 +137,8 @@ import { WithOptionPanelComponent } from './utils/with-option-panel.component';
`
})
export class RdxTooltipAnchorComponent extends OptionPanelBase {
tooltipHtml = signal(generateRandomSentence());

readonly rootDirective1 = viewChild('root1');
readonly rootDirective2 = viewChild('root2');

Expand Down
5 changes: 4 additions & 1 deletion packages/primitives/tooltip/stories/tooltip-animations.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { RdxTooltipContentAttributesComponent } from '../src/tooltip-content-att
import { provideRdxCdkEventService } from '../src/utils/cdk-event.service';
import { containerAlert } from './utils/constants';
import { OptionPanelBase } from './utils/option-panel-base.class';
import { generateRandomSentence } from './utils/rendom-sentence.util';
import styles from './utils/styles.constants';
import { WithOptionPanelComponent } from './utils/with-option-panel.component';

Expand Down Expand Up @@ -77,7 +78,7 @@ import { WithOptionPanelComponent } from './utils/with-option-panel.component';
<button class="TooltipClose reset" rdxTooltipClose aria-label="Close">
<lucide-angular [img]="XIcon" size="16" style="display: flex" />
</button>
Add to library
{{ tooltipHtml() }}
<div
class="TooltipArrow"
[width]="arrowWidth()"
Expand All @@ -93,6 +94,8 @@ import { WithOptionPanelComponent } from './utils/with-option-panel.component';
`
})
export class RdxTooltipAnimationsComponent extends OptionPanelBase {
tooltipHtml = signal(generateRandomSentence());

readonly rootDirective = viewChild(RdxTooltipRootDirective);

readonly MountainSnowIcon = MountainSnow;
Expand Down
7 changes: 5 additions & 2 deletions packages/primitives/tooltip/stories/tooltip-default.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import { Component, viewChild } from '@angular/core';
import { Component, signal, viewChild } from '@angular/core';
import { FormsModule } from '@angular/forms';
import { LucideAngularModule, MountainSnow, TriangleAlert, X } from 'lucide-angular';
import { RdxTooltipModule, RdxTooltipRootDirective } from '../index';
import { RdxTooltipContentAttributesComponent } from '../src/tooltip-content-attributes.component';
import { provideRdxCdkEventService } from '../src/utils/cdk-event.service';
import { containerAlert } from './utils/constants';
import { OptionPanelBase } from './utils/option-panel-base.class';
import { generateRandomSentence } from './utils/rendom-sentence.util';
import styles from './utils/styles.constants';
import { WithOptionPanelComponent } from './utils/with-option-panel.component';

Expand Down Expand Up @@ -52,7 +53,7 @@ import { WithOptionPanelComponent } from './utils/with-option-panel.component';
<button class="reset TooltipClose" rdxTooltipClose aria-label="Close">
<lucide-angular [img]="XIcon" size="12" style="display: flex" />
</button>
Add to library
{{ tooltipHtml() }}
<div
class="TooltipArrow"
[width]="arrowWidth()"
Expand All @@ -68,6 +69,8 @@ import { WithOptionPanelComponent } from './utils/with-option-panel.component';
`
})
export class RdxTooltipDefaultComponent extends OptionPanelBase {
tooltipHtml = signal(generateRandomSentence());

readonly rootDirective = viewChild(RdxTooltipRootDirective);

readonly MountainSnowIcon = MountainSnow;
Expand Down
7 changes: 5 additions & 2 deletions packages/primitives/tooltip/stories/tooltip-events.components.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Component, viewChild } from '@angular/core';
import { Component, signal, viewChild } from '@angular/core';
import { FormsModule } from '@angular/forms';
import { RdxPositionAlign, RdxPositionSide } from '@radix-ng/primitives/core';
import { LucideAngularModule, MountainSnow, TriangleAlert, X } from 'lucide-angular';
Expand All @@ -7,6 +7,7 @@ import { RdxTooltipContentAttributesComponent } from '../src/tooltip-content-att
import { provideRdxCdkEventService } from '../src/utils/cdk-event.service';
import { containerAlert } from './utils/constants';
import { OptionPanelBase } from './utils/option-panel-base.class';
import { generateRandomSentence } from './utils/rendom-sentence.util';
import styles from './utils/styles.constants';
import { WithOptionPanelComponent } from './utils/with-option-panel.component';

Expand Down Expand Up @@ -56,7 +57,7 @@ import { WithOptionPanelComponent } from './utils/with-option-panel.component';
<button class="reset TooltipClose" rdxTooltipClose aria-label="Close">
<lucide-angular [img]="XIcon" size="12" style="display: flex" />
</button>
Add to library
{{ tooltipHtml() }}
<div
class="TooltipArrow"
[width]="arrowWidth()"
Expand All @@ -72,6 +73,8 @@ import { WithOptionPanelComponent } from './utils/with-option-panel.component';
`
})
export class RdxTooltipEventsComponent extends OptionPanelBase {
tooltipHtml = signal(generateRandomSentence());

readonly rootDirective = viewChild(RdxTooltipRootDirective);

readonly MountainSnowIcon = MountainSnow;
Expand Down
7 changes: 5 additions & 2 deletions packages/primitives/tooltip/stories/tooltip-initially-open.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import { Component, viewChild } from '@angular/core';
import { Component, signal, viewChild } from '@angular/core';
import { FormsModule } from '@angular/forms';
import { LucideAngularModule, MountainSnow, TriangleAlert, X } from 'lucide-angular';
import { RdxTooltipModule, RdxTooltipRootDirective } from '../index';
import { RdxTooltipContentAttributesComponent } from '../src/tooltip-content-attributes.component';
import { provideRdxCdkEventService } from '../src/utils/cdk-event.service';
import { containerAlert } from './utils/constants';
import { OptionPanelBase } from './utils/option-panel-base.class';
import { generateRandomSentence } from './utils/rendom-sentence.util';
import styles from './utils/styles.constants';
import { WithOptionPanelComponent } from './utils/with-option-panel.component';

Expand Down Expand Up @@ -53,7 +54,7 @@ import { WithOptionPanelComponent } from './utils/with-option-panel.component';
<button class="reset TooltipClose" rdxTooltipClose aria-label="Close">
<lucide-angular [img]="XIcon" size="12" style="display: flex" />
</button>
Add to library
{{ tooltipHtml() }}
<div
class="TooltipArrow"
[width]="arrowWidth()"
Expand All @@ -69,6 +70,8 @@ import { WithOptionPanelComponent } from './utils/with-option-panel.component';
`
})
export class RdxTooltipInitiallyOpenComponent extends OptionPanelBase {
tooltipHtml = signal(generateRandomSentence());

readonly rootDirective = viewChild(RdxTooltipRootDirective);

readonly MountainSnowIcon = MountainSnow;
Expand Down
Loading
Loading