Reformat changepoint Slack message#94
Open
mohit-sheth wants to merge 5 commits intoredhat-performance:mainfrom
Open
Reformat changepoint Slack message#94mohit-sheth wants to merge 5 commits intoredhat-performance:mainfrom
mohit-sheth wants to merge 5 commits intoredhat-performance:mainfrom
Conversation
Use the real step name (e.g. payload-control-plane-6nodes-openshift-qe-orion-udn-l3) in the preview header instead of a generic description (e.g. orion changepoint detection failure), since many different steps share the same keyword. Signed-off-by: Mohit Sheth <msheth@redhat.com>
When a prow job failure is classified as an orion/changepoint issue, display a clickable link to the changepoint visualization HTML in GCS instead of the generic Error Logs Preview. The visualization URL is constructed by probing the job's GCS artifacts directory for the matching step subfolder and linking to the HTML file if present. Also threads step_name through analyze_prow_artifacts return tuple so callers can resolve the correct artifact path, and extracts duplicated failure_desc logic into a shared helper. Signed-off-by: Mohit Sheth <msheth@redhat.com>
…ation, and Slack fixes Show all changepoints individually with separator bars, numbering, regressed metrics in title, and version info. Separate preview (5 PRs with truncation) from full error log file (all PRs, no char limit). Fix Slack file rendering as binary and "file not found" race condition. Merge viz link into preview header to reduce thread messages. Ensure full error log appears just before job history in thread order. Signed-off-by: Mohit Sheth <msheth@redhat.com>
This was referenced Feb 25, 2026
…edTuple Replace the 6-element positional tuple with a ProwAnalysisResult NamedTuple using keyword construction at all return sites. Improves readability and makes field ordering errors less likely across the 6 return paths. Signed-off-by: Mohit Sheth <msheth@redhat.com>
Collaborator
|
@mohit-sheth also buildURL for the change points please. |
Collaborator
Author
@vishnuchalla added, thanks!
|
mohit-sheth
force-pushed
the
changepoint-visualization
branch
from
82b0ad5 to
e61a51c
Compare
When a changepoint is detected, insert the prow build URL after each "Previous:" version line in the full error log file uploaded to Slack.
mohit-sheth
force-pushed
the
changepoint-visualization
branch
from
e61a51c to
8887238
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites changepoint extraction and Slack notification to display all changepoints with clean formatting,
separate preview from full content, and fix multiple Slack rendering issues.
Changes
Show all changepoints individually
Each changepoint is now rendered as its own formatted block with separator bars, numbering (Changepoint 1 of
2: metric: +X.XX%), version info, and PR list — instead of being joined into a single string that got
truncated mid-way.
Separate preview vs full content
Preview (inline in Slack): shows 5 PRs per changepoint with ... and N more
Full error log (file upload): contains all PRs with no character limit
Fix Slack file rendering as "binary"
Switched from io.BytesIO + .log to content= string + .txt so Slack recognizes the upload as text.
Before
After
