[ID-358] App config version control integration #498
Conversation
driven/github/adapter.go
Outdated
|
|
||
| // UpdateCachedWebhookConfigs updates the webhook configs cache | ||
| func (sa *Adapter) UpdateCachedWebhookConfigs() error { | ||
| return sa.cacheWebhookConfigs() |
There was a problem hiding this comment.
There is currently an issue here when the webhook configs are updated. The cache will be updated on whichever instance receives the webhook request, but the other instances will not get the updated version. The easiest solution would be to store these webhook configs into the database somewhere and setting a listener so that all instances will be notified of updates.
shurwit
left a comment
shurwit
left a comment
There was a problem hiding this comment.
Thanks @siqiz7, LGTM! I have restructured this to abstract all GitHub specific implementations into the github package. This is so we can support different VCS systems in the future.
@petyos, please take a look when you get a chance. Also please note that there are several related issues that build on this one that we will request your review on soon as well. Thanks!
|
Hi @petyos, @roberlander2 and I noticed that we will need to make a change here to handle creating a new version object in the app type if a new app config is added with a version number that doesn't currently exist. Otherwise, we will end up with conflicting version number IDs between the app types and app configs. We will address this before merging. |
Resolves #358