Skip to content

[#674] Refactor account auth types #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
roberlander2 wants to merge 110 commits into
base: 659-webauthn-authentication
Choose a base branch
from
Open

[#674] Refactor account auth types #675

roberlander2 wants to merge 110 commits into from

Conversation

@roberlander2
Copy link
Contributor

@roberlander2 roberlander2 commented Sep 11, 2023

Description

This PR refactors account auth types into account identifiers and account auth types. This allows a user to sign in with any combination of identifier and auth type on the account. It also allows users to link and unlink identifiers and auth types independently, unless dealing with external auth types and identifiers (e.g., OIDC).

Resolves #674

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

  • Immediately
  • Within a week
  • When possible

Type of changes

Please select a relevant option:

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

roberlander2 and others added 30 commits June 14, 2023 11:39
@roberlander2
Merge pull request #9 from rokwire/659-webauthn-authentication
e3cf5ed 
[#659] WebAuthn authentication
@shurwit
add configs for authenticator selection to supported auth type params (…
00fc6e3 
…#10)
@roberlander2
start adding verification types (contains errors) [#665]
adb1829
@roberlander2
continue splitting auth and verification types [#665]
9c2e84d
@shurwit
Merge branch 'develop' of github.com:rokwire/core-building-block into…
50f4f35 
… rokwire-develop
@shurwit
Merge branch 'rokwire-develop' into develop
6817f28
@roberlander2
finish implementing password auth type, start code verification type,…
268d745 
… add phone verifier interface [#665]
@roberlander2
finish refactoring identifier, auth types, start updating apis [#665]
14e051e
@shurwit
upgrade dependencies
11f06ed
@roberlander2
finish fixing errors [#665]
bd94830
@roberlander2
merged changes from develop
7124ecf
@roberlander2
merged changes from 659-webauthn-authentication
9dcad2e
@roberlander2
fix passkey errors [#665]
34941e5
@roberlander2
bug fixes, email with passkey not working because no params in email …
04531c8 
…auth type
@roberlander2
update identifier impl and auth impl getters to better handle backwar…
446e3f1 
…ds compatibility (has errors)
@roberlander2
bug fixes, email and passkey not completing registration
99f4def
@shurwit
Merge branch 'develop' of github.com:rokwire/core-building-block into…
140678f 
… rokwire-develop
@shurwit
Merge branch 'rokwire-develop' into develop
f4a2bae
@roberlander2
add json omitempty tags to credential structs
98e6210
@roberlander2
better identifier type parsing
50342fb
@roberlander2
passkeys using email and username identifiers working
c4096f3
@roberlander2
start fixing phone, passkey auth
7dc7ad1
@roberlander2
bug fixes for phone and passkey, better error messages
293462e
@roberlander2
simplify phone verifier interface
f7456f7
@roberlander2
phone auth type link working, add authCommunicationChannel interface …
5bdc6c7 
…to handle verification functions
@roberlander2
add ability to link webauthn credentials to accounts
b55a248
@roberlander2
only set username if empty
a60ff2d
@akshadpai
Change messages handling for verification
6e9e996
@roberlander2
remove commented blocks
ac7970c
@roberlander2
merged changes from develop
9e1e7bf
@roberlander2
merged changes from 659-webauthn-authentication
1f97388
@roberlander2
updates and fixes for conde_oidc, started refactoring email and phone…
94910ec 
… from profile, username from account into identifiers
@roberlander2
fix build errors
363108d
@roberlander2
start handling external email identifiers
f310f48
@roberlander2
implement profile email and phone and account username migrations
7ce68ab
@roberlander2
set sensitive flags for email and phone migrations
c47d21a
@roberlander2
finish implementing identifier sensitive field, return profile email,…
a6c2092 
… phone and username for BC
@roberlander2
disallow updating account username to empty string
34d03fe
@roberlander2
add sensitive field to account identifier api model
1ece6b8
@roberlander2
bug fixes
eba689c
@roberlander2
mark email as external if it matches external email field
1388e1d
@roberlander2
usernames verified by default, identifiers used to sign up with webau…
06596bc 
…thn unverified by default
@roberlander2
auth type unlink bug fixes
91aa44e
@roberlander2
simplify link auth type transaction, add app type identifier to webau…
9e4805b 
…thn aat params
@roberlander2
fix link docs example
248cb29
@roberlander2
return identifiers on auth type link and unlink
d17615c
@roberlander2
improve external identifier migration, add IsEmailVerified flag
8a92518
@roberlander2 roberlander2 mentioned this pull request Oct 3, 2023
Merged
18 tasks
roberlander2 and others added 3 commits October 3, 2023 16:38
@roberlander2
do not change email sensitivity on update external identifiers
f7bc6ed
@roberlander2
remove API docs comment
0f63f07
@roberlander2 @shurwit @akshadpai
ROKMETRO fixes (#679)
4eb98cc 
* add app-env.json and update port

* Update app-env.json

* Update app-env.json

* update detect-secrets, update secrets baseline

* update secrets baseline

* update makefile versioning

* Update Makefile

Fix typo

* print version

* upgrade go to v1.20

* fix secrets

* initial webauthn implementation (in progress)

* refactor webauthn to handle credentials, update docs

* avoid creating inaccessible accounts

* fix webauthn registration issues, add webauthn test page

* fix webauthn login flow

* update changelog

* [#659] WebAuthn authentication (#7)

* initial webauthn implementation (in progress)

* refactor webauthn to handle credentials, update docs

* avoid creating inaccessible accounts

* fix webauthn registration issues, add webauthn test page

* fix webauthn login flow

* update changelog

* fix error handling

* fix login issues for mobile

* upgrade dependencies

* [#659] webauthn authentication (#8)

* initial webauthn implementation (in progress)

* refactor webauthn to handle credentials, update docs

* avoid creating inaccessible accounts

* fix webauthn registration issues, add webauthn test page

* fix webauthn login flow

* update changelog

* fix error handling

* fix login issues for mobile

* upgrade dependencies

* add webauthn to account check types

* add configs for authenticator selection to supported auth type params (#10)

* upgrade dependencies

* [#665] Decouple authentication and verification mechanisms (#13)

* add configs for authenticator selection to supported auth type params

* start adding verification types (contains errors) [#665]

* continue splitting auth and verification types [#665]

* finish implementing password auth type, start code verification type, add phone verifier interface [#665]

* finish refactoring identifier, auth types, start updating apis [#665]

* finish fixing errors [#665]

* fix passkey errors [#665]

* bug fixes, email with passkey not working because no params in email auth type

* update identifier impl and auth impl getters to better handle backwards compatibility (has errors)

* bug fixes, email and passkey not completing registration

* add json omitempty tags to credential structs

* better identifier type parsing

* passkeys using email and username identifiers working

* start fixing phone, passkey auth

* bug fixes for phone and passkey, better error messages

* simplify phone verifier interface

* phone auth type link working, add authCommunicationChannel interface to handle verification functions

* add ability to link webauthn credentials to accounts

* only set username if empty

* Change messages handling for verification

* remove commented blocks

* cleanup

* return verified auth types when cannot find account with username but not identifier

* bug fixes

* fix phone auth type docs

---------

Co-authored-by: Stephen Hurwit <sjhurwit@gmail.com>
Co-authored-by: akshadpai <akshadpai01@gmail.com>

* add missing verify email env var to app-env.json

* Auth-verify split fixes (#16)

* bug fixes

* update secrets baseline

* fix issues introduced by nullable device IDs

* fix username format

* update secrets baseline

* fix sign up bug

* disable request docs validation

* fix startup error for caching auth type

* fix pkce generation

* fix random string interface

* set user agent for oidc requests

* revert auth type changes

* revert core models, go mod, auth interface impl, remove phone verifier interface

* revert web package webauthn additions, update API docs

* fix storage files

* revert auth.go

---------

Co-authored-by: Stephen Hurwit <sjhurwit@gmail.com>
Co-authored-by: Stephen Hurwit <10472810+shurwit@users.noreply.github.com>
Co-authored-by: akshadpai <akshadpai01@gmail.com>
@roberlander2 roberlander2 changed the base branch from 659-webauthn-authentication to develop October 6, 2023 20:00
@roberlander2 roberlander2 changed the base branch from develop to 659-webauthn-authentication October 6, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petyos petyos Awaiting requested review from petyos petyos is a code owner

@shurwit shurwit Awaiting requested review from shurwit shurwit is a code owner

Assignees

@roberlander2 roberlander2

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@roberlander2 @shurwit @akshadpai