Fixing lifecycle node autostart issue #445 #449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
SteveMacenski
force-pushed
the
lifecycle_2
branch
from
33f6967 to
d9e72e7
Compare
|
Tested, looks good! Thanks |
ahcorde
approved these changes
Mar 17, 2025
Contributor
|
Pulls: #449
|
fujitatomoya
approved these changes
Mar 17, 2025
Contributor
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
RHEL Job got disconnected, i just restarted that. windows failures look unrelated.
Contributor
Author
|
Great, can we merge? |
Member
|
The RHEL job passed, let's go! |
Contributor
|
@SteveMacenski should we backport this to |
Member
Member
|
@Mergifyio backport jazzy |
✅ Backports have been created
|
christophebedard
pushed a commit
that referenced
this pull request
Mar 25, 2025
christophebedard
pushed a commit
that referenced
this pull request
Mar 25, 2025
christophebedard
pushed a commit
that referenced
this pull request
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing lifecycle node autostart issue #445
The issue boils down to the emitting of signals for the first transition in the
transition_ids. It appears that sometimes the Launch system doesn't emit these in order or for whatever reason the second signal is received by the server before the first. By putting them both in a single transition, only the configure signal is emitted and activate is dependent fully on the state transition.Honestly, this is probably how it should have always been implemented, but I didn't think it mattered at the time since I thought ordering was guaranteed.