Skip to content

Qiskit 2 support#326

Open
MoritzWillmann wants to merge 81 commits intosQUlearn:developfrom
MoritzWillmann:qiskit_2_support
Open

Qiskit 2 support#326
MoritzWillmann wants to merge 81 commits intosQUlearn:developfrom
MoritzWillmann:qiskit_2_support

Conversation

@MoritzWillmann
Copy link
Copy Markdown
Collaborator

@MoritzWillmann MoritzWillmann commented Apr 3, 2025

This pull request updates the minimum supported Python version to 3.10 and modernizes Qiskit usage throughout the codebase and documentation. It also removes support for legacy Qiskit and Python 3.9 in CI workflows, updates dependencies, and improves example notebooks to use the latest Qiskit primitives.

Python and dependency updates:

  • Increased the minimum required Python version from 3.9 to 3.10 in documentation, README, and CI workflows, and removed Python 3.9 from test matrices. [1] [2] [3] [4] [5] [6] [7]
  • Updated dependency requirements: increased minimum versions for dill, mapomatic, numpy, qiskit, and related packages in docs/install/install.rst.
  • Updated README and documentation to reflect new minimum Python version and dependency changes. [1] [2]

CI workflow and test improvements:

  • Removed all Python 3.9 jobs and related autoray installation steps from GitHub Actions workflows. [1] [2] [3] [4] [5]
  • Updated Qiskit test jobs to use Qiskit 1.x and Python 3.10–3.13, simplifying installation commands and removing explicit old-version pins. [1] [2] [3]

Example and documentation modernization:

  • Updated Qiskit code examples in the notebook example_executor_qiskit.ipynb to use the new V2 primitives (StatevectorSampler, StatevectorEstimator, BackendSamplerV2, BackendEstimatorV2) and removed deprecated V1 classes and warnings. [1] [2] [3] [4]
  • Updated usage examples in the user guide to use correct Qiskit imports (replacing TwoLocal with n_local).

General cleanup:

  • Adjusted kernel display name in the example notebook for consistency.
  • Updated minor output and execution count changes in the example notebook for clarity. [1] [2] [3] [4] [5] [6] [7]

These updates ensure compatibility with the latest Qiskit versions and improve maintainability by dropping support for outdated Python and Qiskit versions.

@David-Kreplin
Copy link
Copy Markdown
Collaborator

Maybe a good chance to get rid of the qiskit_algorithms, which is only needed for fidelity quantum circuits.
We have fast implementation for that for PennyLane and Qulacs, but not for Qiskit.

@David-Kreplin
Copy link
Copy Markdown
Collaborator

Mapomatic causes problems with Qiskit 2.0 since it also checks for BackendV1 that is depricated in Qiskit 2.0.
I don't know, if they ever gonna update the Mapomatic Package, maybe we have to create a fix and hope someone will merge it and relase a new Mapomatic version.

@MoritzWillmann
Copy link
Copy Markdown
Collaborator Author

Mapomatic causes problems with Qiskit 2.0 since it also checks for BackendV1 that is depricated in Qiskit 2.0. I don't know, if they ever gonna update the Mapomatic Package, maybe we have to create a fix and hope someone will merge it and relase a new Mapomatic version.

Should be fixed now (qiskit-community/mapomatic#77)

@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 1 year.

@github-actions github-actions bot added the Stale label Dec 29, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 32 out of 34 changed files in this pull request and generated 8 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI and others added 3 commits February 24, 2026 08:41
Co-authored-by: MoritzWillmann <44642314+MoritzWillmann@users.noreply.github.com>
Fix unresolved review comments from PR sQUlearn#326 Qiskit 2 support
@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 1 year.

@github-actions github-actions bot added the Stale label Mar 27, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 33 out of 35 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MoritzWillmann MoritzWillmann marked this pull request as ready for review March 31, 2026 12:58
@MoritzWillmann MoritzWillmann requested a review from Copilot March 31, 2026 12:58
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 33 out of 35 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MoritzWillmann MoritzWillmann changed the title WIP: Qiskit 2 support Qiskit 2 support Mar 31, 2026
@MoritzWillmann MoritzWillmann requested review from DennisKleinhans and removed request for DennisKleinhans March 31, 2026 15:42
@github-actions github-actions bot removed the Stale label Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants