-
Notifications
You must be signed in to change notification settings - Fork 426
chore(ci): use GitHub Actions instead of SauceLabs #5548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't delete SauceLabs tho (yet)
It's implicit in the files being in the test directory and long filenames cause problems on windows
easier to maintain and uncovered a few broken tests!
89c3a87 to
8ac4b34
Compare
This reverts commit 6f32328.
wjhsf
commented
Nov 5, 2025
...wc/integration-not-karma/test-hydration/light-dom/slots/nested-and-scoped/x/scoped/scoped.js
Outdated
Show resolved
Hide resolved
lpomerleau
reviewed
Nov 5, 2025
| shadow_mode: [native, synthetic] | ||
| env: | ||
| - '' | ||
| # TODO: Fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What needs fixing?
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A handful of tests are broken in that mode.
lpomerleau
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Turns out SauceLabs is kinda slow. This PR changes us use Playwright in GitHub Actions instead. It's doesn't seem to be much faster, but it does seem to be less flaky. I've also updated the jobs to run everything in parallel instead of sequentially.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item