Skip to content

Add enabled boolean field to CrossmarkPage #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add enabled boolean field to CrossmarkPage #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
045a0f1
Initial plan
Copilot Mar 9, 2026
38a7716
Add enabled boolean field to CrossmarkPage model
Copilot Mar 9, 2026
e8c9942
Change enabled field default to False in CrossmarkPage
Copilot Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file removed __init__.py
View file
Open in desktop
Empty file.
2 changes: 2 additions & 0 deletions opac_schema/v1/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1071,6 +1071,7 @@ def save(self, *args, **kwargs):
class CrossmarkPage(Document):
doi = StringField(required=True)
is_doi_active = BooleanField(required=True, default=True)
enabled = BooleanField(required=True, default=False)
language = StringField(max_length=5, required=True)
url = StringField()
text = StringField()
Expand All @@ -1083,6 +1084,7 @@ class CrossmarkPage(Document):
'indexes': [
'doi',
'is_doi_active',
'enabled',
'language',
'journal',
]
Expand Down
33 changes: 33 additions & 0 deletions tests/test_crossmarkpage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,3 +265,36 @@ def test_create_crossmarkpage_without_text(self):

# then
self.assertIsNone(crossmark_doc.text)

def test_create_crossmarkpage_enabled_default_false(self):
# given
journal = self._make_journal()
crossmark_data = {
'doi': '10.1590/crossmark-policy',
'language': 'en',
'journal': journal,
}

# when
crossmark_doc = CrossmarkPage(**crossmark_data)
crossmark_doc.save()

# then
self.assertFalse(crossmark_doc.enabled)

def test_create_crossmarkpage_enabled_false(self):
# given
journal = self._make_journal()
crossmark_data = {
'doi': '10.1590/crossmark-policy',
'language': 'en',
'journal': journal,
'enabled': False,
}

# when
crossmark_doc = CrossmarkPage(**crossmark_data)
crossmark_doc.save()

# then
self.assertFalse(crossmark_doc.enabled)