Skip to content

Conversation

@mhasself
Copy link
Member

Description

go_to will now accept az=None and/or el=None, in which case the mode for the axis will not be changed. This is an interface change, but the behavior is backwards compatible with current common usage.

Motivation and Context

This is required for star camera surveys, where it is desirable to command azimuth moves while either holding elevation in Stop, or in Preset.

How Has This Been Tested?

Tested with ACU simulator from soaculib. Interface tested with current ocs-web (which does not propagate az=null, el=null) and an updated ocs-web that can activate the feature.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

go_to will now accept az=None and/or el=None, in which case the mode
for the axis will not be changed.  This is an interface change, but
the behavior is backwards compatible with current common usage.  This
is required for star camera surveys with elevation either in Stop or
Preset.
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

It looks like with az and el both optional on go_to that if both are omitted it would be equivalent to a go_to to the current location and wouldn't change modes, is that right?

@BrianJKoopman BrianJKoopman merged commit b91ea60 into main May 20, 2025
5 checks passed
@BrianJKoopman BrianJKoopman deleted the mhasself/acu-passive-goto branch May 20, 2025 14:46
@mhasself
Copy link
Member Author

It looks like with az and el both optional on go_to that if both are omitted it would be equivalent to a go_to to the current location and wouldn't change modes, is that right?

It is a no-op in that case -- the code will basically check that the current position is Sun Safe. So it might return an error (not sun safe), but regardless it will return without doing anything to either axis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants