ACU: Support el_mode='stop' in generate_scan #964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will cause the el axis to be kept in Stop mode for type 1 and 2 scans. The default behavior remains the same as it always was -- the el axis will be in Preset following the initial go_to the start position. The az_only argument in generate_scan was not working as advertised, and does not appear to ever get used, anyway.
Member
Author
|
This has also been tested at site; works as designed. |
6 tasks
BrianJKoopman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Main change is that the azonly argument in generate_scan is replaced by el_mode. Default behavior is the same, which is to leave elevation axis in Preset mode for the (type 1 or type 2) scan. But now you have the option to request el_mode="stop", which will put that axis in Stop for the scan.
The el_mode is also a "scan_param" whose default value can be set in config file and then updated using
set_scan_params.Note although there's an interface change here, the azonly argument does not appear to be used by anyone currently (it's not exposed through ocs-web, even). And the functionality it advertised was not correctly implemented.
Motivation and Context
This is a desired interim behavior for SATP2 while some issues with elevation drive are being investigated.
How Has This Been Tested?
Tested on ACU simulator software. Confirmed old default behavior is reproduced.
Types of changes
Checklist: