Add freshly fetched configs from config poller #1441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogtownsend
requested review from
0xAustinWang,
AmrMohamedRezk,
agusaldasoro,
asoliman92,
chris-de-leon-cll,
Copilot,
tt-cll and
winder
There was a problem hiding this comment.
Pull request overview
This PR adds logging of freshly fetched configuration data from the config poller. The change enhances the debug logging output to include the actual configuration snapshots that were retrieved during the batch refresh operation.
- Added
chainConfigSnapshotandsourceChainConfigsto debug log output
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| c.lggr.Debugw("Batch refreshed configs via chainAccessor", | ||
| "chain", chainSel, | ||
| "latency", time.Since(start), | ||
| "chainConfigSnapshot", chainConfigSnapshot, |
There was a problem hiding this comment.
Logging potentially sensitive configuration data at debug level could expose internal system details in production logs. Consider whether this data contains sensitive information (API keys, private endpoints, etc.) that should not be logged, or restrict this logging to trace level instead of debug level.
Suggested change
| "chainConfigSnapshot", chainConfigSnapshot, | |
| "chainConfigSnapshot", chainConfigSnapshot, | |
| ) | |
| c.lggr.Tracew("Batch refreshed sourceChainConfigs via chainAccessor", | |
| "chain", chainSel, |
tt-cll
previously approved these changes
Dec 3, 2025
amit-momin
previously approved these changes
Dec 3, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.