chore(deps): add support for angular v18 #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaibhavbhalla2505
force-pushed
the
GH-39
branch
from
a7e0b6b to
5fe58b2
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Angular framework and its dependencies from version 17 to version 18 across the search client library. This is a breaking change that adds support for Angular v18 while maintaining backward compatibility documentation.
- Updated all Angular-related dependencies from ^17.3.0 to ^18.0.0
- Updated TypeScript to version ~5.4.3 to align with Angular 18 requirements
- Added version compatibility documentation to clarify usage patterns
Reviewed Changes
Copilot reviewed 6 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sandbox/search-client-example/package.json | Updated Angular dependencies and TypeScript version for the example application |
| packages/search/projects/search-lib/package.json | Updated peer dependencies to Angular 18 for the search library |
| packages/search/projects/search-lib/README.md | Added version compatibility notice documenting Angular 17 vs 18 usage |
| packages/search/projects/search-element/package.json | Updated hash value for the search element package |
| packages/search/package.json | Updated Angular dependencies and build tools to version 18 |
| packages/search/README.md | Added version compatibility notice and updated deprecation message |
Files not reviewed (1)
- packages/search/projects/search-lib/package-lock.json: Language not supported
|
|
||
| - For Angular v17, use @sourceloop/search-client version ^7.x.x. | ||
|
|
||
| - For Angular v18, use @sourceloop/search-client version ^8.x.x |
There was a problem hiding this comment.
The documentation mentions version ^8.x.x for Angular v18, but the package version in the library is still 7.0.1. This creates confusion about which version users should actually use.
Suggested change
| - For Angular v18, use @sourceloop/search-client version ^8.x.x | |
| - For Angular v18, use @sourceloop/search-client version ^7.x.x |
| Search-client now supports Angular v17, we will provide support for the older version that is based on Angular v14 till 30th August 2025 . | ||
| - For Angular v17, use @sourceloop/search-client version ^7.x.x. | ||
|
|
||
| - For Angular v18, use @sourceloop/search-client version ^8.x.x |
There was a problem hiding this comment.
The documentation states users should use version ^8.x.x for Angular v18, but this version doesn't appear to exist yet. The package version remains at 7.0.1, which could mislead users.
Suggested change
| - For Angular v18, use @sourceloop/search-client version ^8.x.x | |
| - For Angular v18, use @sourceloop/search-client version ^7.x.x until version ^8.x.x is released. | |
| **Note:** Version ^8.x.x is not yet available. Please check the [npm registry](https://www.npmjs.com/package/@sourceloop/search-client) for updates. |
BREAKING CHANGE: yes GH-39
rohit-sourcefuse
approved these changes
Aug 6, 2025
vaibhavbhalla2505
force-pushed
the
GH-39
branch
from
5fe58b2 to
a4f0d6f
Compare
piyushsinghgaur1
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
yes
Description
Updated the angular version and its dependencies
Support for angular version 18
Fixes # (issue)
GH-39
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: