Skip to content

chore(deps): add support for angular v18 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vaibhavbhalla2505 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(deps): add support for angular v18 #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 8 additions & 2 deletions packages/search/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,15 @@

An Angular module that exports a component that can enable users to search over configured models using the search microservice provided in the sourceloop microservice catalog.

### Deprecation Notice
## Version Compatibility Notice

Search-client now supports Angular v17, we will provide support for the older version that is based on Angular v14 till 30th August 2025 .
- For Angular v17, use @sourceloop/search-client version ^7.x.x.

- For Angular v18, use @sourceloop/search-client version ^8.x.x
Copy link

Copilot AI Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation states that for Angular v18, version ^8.x.x should be used, but this conflicts with the current package version (7.0.1) that now supports Angular v18. Either the version should be bumped to 8.x.x or the documentation should be updated to reflect the correct version.

Suggested change
- For Angular v18, use @sourceloop/search-client version ^8.x.x
- For Angular v18, use @sourceloop/search-client version ^7.x.x

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation states users should use version ^8.x.x for Angular v18, but this version doesn't appear to exist yet. The package version remains at 7.0.1, which could mislead users.

Suggested change
- For Angular v18, use @sourceloop/search-client version ^8.x.x
- For Angular v18, use @sourceloop/search-client version ^7.x.x until version ^8.x.x is released.
**Note:** Version ^8.x.x is not yet available. Please check the [npm registry](https://www.npmjs.com/package/@sourceloop/search-client) for updates.

Copilot uses AI. Check for mistakes.

## Deprecation Notice

Search-client now supports Angular v17 and v18, we will provide support for the older version that is based on Angular v14 till 30th August 2025 .

## Angular Module

Expand Down
Loading