Skip to content

Content Presentation#12

Open
DerekJB1987 wants to merge 2 commits intomasterfrom
content-requirements
Open

Content Presentation#12
DerekJB1987 wants to merge 2 commits intomasterfrom
content-requirements

Conversation

@DerekJB1987
Copy link
Collaborator

@DerekJB1987 DerekJB1987 commented Feb 14, 2019

Issue 2 Content Presentation

I added the acceptance criteria that was provided in the User Story: Content Presentation into the last

columns so registered uses could easily identify what the guidelines are for content presentation.

Additional Information

  • None required to work with anyone's local dev environment.

Requested Guidance

  • Please review the content that has been changed in the third column from the text that was used in the prior two columns in the
    container above the footer.

<h2>Heading</h2>
<p>Donec sed odio dui. Cras justo odio, dapibus ac facilisis in, egestas eget quam. Vestibulum id ligula porta felis euismod semper. Fusce dapibus, tellus ac cursus commodo, tortor mauris condimentum nibh, ut fermentum massa justo sit amet risus.</p>
<h2>Content Presentation Guidelines</h2>
<p><li>1) Registered Users have the ability to upload both images as well as a file that has text,</li>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than list bullet items here within the paragraph element, try changing the paragraph elements to an ordered list and remove the numbers from each line.

Suggested change
<p><li>1) Registered Users have the ability to upload both images as well as a file that has text,</li>
<ol>
<li>Registered Users have the ability to upload both images as well as a file that has text,</li>

<h2>Content Presentation Guidelines</h2>
<p><li>1) Registered Users have the ability to upload both images as well as a file that has text,</li>
<li>2) Registered users are provided the acceptable file formats for uploading either images or files with text,</li>
<li>3) The user interface components for a registered user must be operable and allow the user to discuss any poem with other users.</li></p>
Copy link
Collaborator

@dineenlauren dineenlauren Feb 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you'll want to change the closing paragraph tag to a closing ordered list tag:

Suggested change
<li>3) The user interface components for a registered user must be operable and allow the user to discuss any poem with other users.</li></p>
<li>The user interface components for a registered user must be operable and allow the user to discuss any poem with other users.</li>
</ol>

<p>Donec sed odio dui. Cras justo odio, dapibus ac facilisis in, egestas eget quam. Vestibulum id ligula porta felis euismod semper. Fusce dapibus, tellus ac cursus commodo, tortor mauris condimentum nibh, ut fermentum massa justo sit amet risus.</p>
<h2>Content Presentation Guidelines</h2>
<p><li>1) Registered Users have the ability to upload both images as well as a file that has text,</li>
<li>2) Registered users are provided the acceptable file formats for uploading either images or files with text,</li>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove " 2) " here from the list.

@dineenlauren
Copy link
Collaborator

Once the changes above are made, I believe this is ready to be pulled into Master.

<span class="icon-bar"></span>
</button>
<a class="navbar-brand" href="#">Project name</a>
<a class="navbar-brand" href="#">PDG Poetry Project</a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is important for our poetry website's name to be on the navbar. This branch passes and I endorse merge.

Copy link
Collaborator

@cherylac cherylac Mar 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unable to really get anything running in my environment, but I agree with Dineen's changes and with Tony's comments about the website's name. 👍 If it works after changes, ok to ship.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants