Conversation
| <h2>Heading</h2> | ||
| <p>Donec sed odio dui. Cras justo odio, dapibus ac facilisis in, egestas eget quam. Vestibulum id ligula porta felis euismod semper. Fusce dapibus, tellus ac cursus commodo, tortor mauris condimentum nibh, ut fermentum massa justo sit amet risus.</p> | ||
| <h2>Content Presentation Guidelines</h2> | ||
| <p><li>1) Registered Users have the ability to upload both images as well as a file that has text,</li> |
There was a problem hiding this comment.
Rather than list bullet items here within the paragraph element, try changing the paragraph elements to an ordered list and remove the numbers from each line.
| <p><li>1) Registered Users have the ability to upload both images as well as a file that has text,</li> | |
| <ol> | |
| <li>Registered Users have the ability to upload both images as well as a file that has text,</li> |
| <h2>Content Presentation Guidelines</h2> | ||
| <p><li>1) Registered Users have the ability to upload both images as well as a file that has text,</li> | ||
| <li>2) Registered users are provided the acceptable file formats for uploading either images or files with text,</li> | ||
| <li>3) The user interface components for a registered user must be operable and allow the user to discuss any poem with other users.</li></p> |
There was a problem hiding this comment.
Here you'll want to change the closing paragraph tag to a closing ordered list tag:
| <li>3) The user interface components for a registered user must be operable and allow the user to discuss any poem with other users.</li></p> | |
| <li>The user interface components for a registered user must be operable and allow the user to discuss any poem with other users.</li> | |
| </ol> |
| <p>Donec sed odio dui. Cras justo odio, dapibus ac facilisis in, egestas eget quam. Vestibulum id ligula porta felis euismod semper. Fusce dapibus, tellus ac cursus commodo, tortor mauris condimentum nibh, ut fermentum massa justo sit amet risus.</p> | ||
| <h2>Content Presentation Guidelines</h2> | ||
| <p><li>1) Registered Users have the ability to upload both images as well as a file that has text,</li> | ||
| <li>2) Registered users are provided the acceptable file formats for uploading either images or files with text,</li> |
There was a problem hiding this comment.
Remove " 2) " here from the list.
|
Once the changes above are made, I believe this is ready to be pulled into Master. |
| <span class="icon-bar"></span> | ||
| </button> | ||
| <a class="navbar-brand" href="#">Project name</a> | ||
| <a class="navbar-brand" href="#">PDG Poetry Project</a> |
There was a problem hiding this comment.
It is important for our poetry website's name to be on the navbar. This branch passes and I endorse merge.
There was a problem hiding this comment.
I was unable to really get anything running in my environment, but I agree with Dineen's changes and with Tony's comments about the website's name. 👍 If it works after changes, ok to ship.
Issue 2 Content Presentation
I added the acceptance criteria that was provided in the User Story: Content Presentation into the last
Additional Information
Requested Guidance