Skip to content

Content Presentation #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DerekJB1987 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Content Presentation #12

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64cb81a
pushing content requirements
DerekJB1987 Feb 14, 2019
c68b2b6
removed href link in footer
DerekJB1987 Feb 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
<span class="icon-bar"></span>
<span class="icon-bar"></span>
</button>
<a class="navbar-brand" href="#">Project name</a>
<a class="navbar-brand" href="#">PDG Poetry Project</a>
Copy link
Copy Markdown
Collaborator

@ItalianJedi ItalianJedi Feb 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is important for our poetry website's name to be on the navbar. This branch passes and I endorse merge.

Copy link
Copy Markdown
Collaborator

@cherylac cherylac Mar 16, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unable to really get anything running in my environment, but I agree with Dineen's changes and with Tony's comments about the website's name. 👍 If it works after changes, ok to ship.

</div>
<div id="navbar" class="navbar-collapse collapse">
<form class="navbar-form navbar-right" role="form">
Expand Down Expand Up @@ -75,8 +75,10 @@ <h2>Heading</h2>
<p><a class="btn btn-default" href="#" role="button">View details &raquo;</a></p>
</div>
<div class="col-md-4">
<h2>Heading</h2>
<p>Donec sed odio dui. Cras justo odio, dapibus ac facilisis in, egestas eget quam. Vestibulum id ligula porta felis euismod semper. Fusce dapibus, tellus ac cursus commodo, tortor mauris condimentum nibh, ut fermentum massa justo sit amet risus.</p>
<h2>Content Presentation Guidelines</h2>
<p><li>1) Registered Users have the ability to upload both images as well as a file that has text,</li>
Copy link
Copy Markdown
Collaborator

@dineenlauren dineenlauren Feb 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than list bullet items here within the paragraph element, try changing the paragraph elements to an ordered list and remove the numbers from each line.

Suggested change
<p><li>1) Registered Users have the ability to upload both images as well as a file that has text,</li>
<ol>
<li>Registered Users have the ability to upload both images as well as a file that has text,</li>

<li>2) Registered users are provided the acceptable file formats for uploading either images or files with text,</li>
Copy link
Copy Markdown
Collaborator

@dineenlauren dineenlauren Feb 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove " 2) " here from the list.

<li>3) The user interface components for a registered user must be operable and allow the user to discuss any poem with other users.</li></p>
Copy link
Copy Markdown
Collaborator

@dineenlauren dineenlauren Feb 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you'll want to change the closing paragraph tag to a closing ordered list tag:

Suggested change
<li>3) The user interface components for a registered user must be operable and allow the user to discuss any poem with other users.</li></p>
<li>The user interface components for a registered user must be operable and allow the user to discuss any poem with other users.</li>
</ol>

<p><a class="btn btn-default" href="#" role="button">View details &raquo;</a></p>
</div>
</div>
Expand Down