[PR-25818][Wallet] Track link click #419
Open
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuravel
requested changes
Nov 13, 2025
| {{ "https://example.com" | track_link_click: "query_42" }} | ||
| Returns ``https://talkable.com/public/[[site_slug]]/wallet_link_clicks/track?identifier=query_42&localization_key=wallet_link_click_query_42``. After successful click, user will be redirected to the original link. |
Member
There was a problem hiding this comment.
Where's example.com in this link? What's wallet_link_click_query_42 ? How does this work?
cc @Doimhneacht
Contributor
There was a problem hiding this comment.
@zhuravel Please see the task description. The example.com is supposed to be stored in a localization.
By the way, @ilovepinkpony1, we have concluded during the scoping or grooming that we don't need the localization key. We can generate the key deterministically to later know its name in the proxy controller.
Doimhneacht
requested changes
Nov 18, 2025
| {{ "https://example.com" | track_link_click: "query_42" }} | ||
| Returns ``https://talkable.com/public/[[site_slug]]/wallet_link_clicks/track?identifier=query_42&localization_key=wallet_link_click_query_42``. After successful click, user will be redirected to the original link. |
Contributor
There was a problem hiding this comment.
Suggested change
| Returns ``https://talkable.com/public/[[site_slug]]/wallet_link_clicks/track?identifier=query_42&localization_key=wallet_link_click_query_42``. After successful click, user will be redirected to the original link. | |
| Returns ``https://talkable.com/public/[[site_slug]]/wallet_link_clicks/track?identifier=query_42``. After a click, the user will be redirected to the original link (``https://example.com``). |
Contributor
There was a problem hiding this comment.
Oh, and now that I'm looking at it, I think we should move the controller into campaign scope, otherwise, we don't know where to look for the localization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Stories