Skip to content

[PR-25818][Wallet] Track link click #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+13 −0
Open

[PR-25818][Wallet] Track link click #419

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5abf1f1
added new filter: wallet link click
ilovepinkpony1 Nov 11, 2025
7dd7b84
Update filter name for wallet link click to use underscore format
ilovepinkpony1 Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions source/campaigns/editor/filters.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -993,6 +993,19 @@ This example can be used in ``Email sending condition`` of Advocate Offer Email

|hr|

wallet\_track\_link\_click
.......................

This filter generates a public link that can be used to track wallet link clicks.

.. code-block:: liquid

{{ "https://example.com" | track_link_click: "query_42" }}

Returns ``https://talkable.com/public/[[site_slug]]/wallet_link_clicks/track?identifier=query_42&localization_key=wallet_link_click_query_42``. After successful click, user will be redirected to the original link.
Copy link
Member

@zhuravel zhuravel Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's example.com in this link? What's wallet_link_click_query_42 ? How does this work?
cc @Doimhneacht

Copy link
Contributor

@Doimhneacht Doimhneacht Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhuravel Please see the task description. The example.com is supposed to be stored in a localization.

By the way, @ilovepinkpony1, we have concluded during the scoping or grooming that we don't need the localization key. We can generate the key deterministically to later know its name in the proxy controller.

Copy link
Contributor

@Doimhneacht Doimhneacht Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Returns ``https://talkable.com/public/[[site_slug]]/wallet_link_clicks/track?identifier=query_42&localization_key=wallet_link_click_query_42``. After successful click, user will be redirected to the original link.
Returns ``https://talkable.com/public/[[site_slug]]/wallet_link_clicks/track?identifier=query_42``. After a click, the user will be redirected to the original link (``https://example.com``).

Copy link
Contributor

@Doimhneacht Doimhneacht Nov 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and now that I'm looking at it, I think we should move the controller into campaign scope, otherwise, we don't know where to look for the localization.


|hr|

qr\_code
........

Expand Down