optimize container lookup with early exit using find() #1432
+10
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Optimize container lookup logic in src/pure.js by replacing forEach with find() to enable an early exit and reduce unnecessary iteration when retrieving an existing root entry.
Why:
forEach continues executing even after a match is found, doing extra iterations
find() stops immediately, improving performance
clearer semantic intent — we want the first match
beneficial in scenarios with many mounted containers
preserves the existing behavior and requires no API changes
How:
Replaced the container reuse lookup code:
with:
This ensures faster lookup and avoids unnecessary looping.
Checklist:
Documentation added to the docs site (N/A — internal optimization)
Tests (existing tests already cover container reuse behavior)
TypeScript definitions updated (N/A — no type changes)
Ready to be merged
Additional comments:
This is a safe, contained performance optimization with no functional changes to the public interface. The internal logic is now more efficient and easier to maintain.