Skip to content

optimize container lookup with early exit using find() #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+10 −8
Closed

optimize container lookup with early exit using find() #1432

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed2fea9
issue 1430
divya2212001 Dec 2, 2025
1b196ea
issue #1430
divya2212001 Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/pure.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,14 +283,16 @@ function render(
// they're passing us a custom container or not.
mountedContainers.add(container)
} else {
mountedRootEntries.forEach(rootEntry => {
// Else is unreachable since `mountedContainers` has the `container`.
// Only reachable if one would accidentally add the container to `mountedContainers` but not the root to `mountedRootEntries`
/* istanbul ignore else */
if (rootEntry.container === container) {
root = rootEntry.root
}
})
const entry = mountedRootEntries.find(
rootEntry => rootEntry.container === container,
)

if (entry) {
root = entry.root
}
// Else is unreachable since `mountedContainers` has the `container`.
// Only reachable if one would accidentally add the container to `mountedContainers` but not the root to `mountedRootEntries`
/* istanbul ignore else */
}

return renderRoot(ui, {
Expand Down
Loading