Clean up stale code identified by static analysis

[robinplace]

Static analysis with Roslynator reveals quite a few unused files, classes, & methods. Removing these means less total code to keep track of for everyone going forward.

[robinplace]

Serializer.cs is FileIO.cs but with unused classes removed. I renamed it because all it does now is serialize-deserialize.

[thomaswp]

Makes me a bit sad to see it go, since this was the original way the mod worked, but there's no active plans to add an actual replay system into the mod, and if we did we'd want to reimplement it anyway.

[thomaswp]

This is quite useful code. It doesn't go in the deployed mod, but it's useful for dev. Is there a nice way to mark that for your static analysis tool?

[thomaswp]

I realize this is actually the method that probably should used, rather than calling the TickingService's directly. Otherwise saving during a pause wouldn't happen until the next tick. So we should keep that

[thomaswp]

Thanks for the cleanup. I've regretted not starting with a good import organization setting on. I suppose we should be consistent - I'll follow up with a comment about that.

Two main changes (see comments):

• ReflectionUtils is still used, just only in dev
• FinishFullTickifNeededAndThen should be used.

I can fix both of those and merge.

[thomaswp]

So I assume for imports the simplest thing is just to be consistent in using VS's built-in remove unused and sort actions on save? That's harder to enforce in the repo. I think it's probably good enough to just put that in the readme to keep overhead lower and avoid external tools, but let me know if you have a strong opinion otherwise.

[thomaswp]

Here I've changed it to use the ReaplyService method directly so it's no longer unused.

[thomaswp]

Hmm, so unfortunately your static analysis tool seems to have been far too overaggressive on removing imports, especially those needed for HarmonyPatches, both the Harmony import itself and also the classes used in it. So right now this PR isn't usable. Did you actually get it to compile on your end?

I see a few options:

• Manually go back and add all the deleted imports that were missing.
• Start a new PR using a more conservative cleanup tool, keeping the modifications I made here for "dead code" that's still useful.

[thomaswp]

This is also a note to self that once this is cleaned up, I should test to make sure that saving on pause doesn't cause any unforeseen issues with the change I made...

[robinplace]

The way to enforce this going forward is definitely a CI job that runs against PRs. We can configure such that build & lint tests get run automatically on every incoming PR. That way authors get feedback & can fix issues themselves.

GitHub actions are free for public repositories & there's a ton we can do with them to take effort off your back (it will also catch if e.g. VS Code's built in import cleanup tool kills the build lol).