feat(acp): Add OS-level sandboxing for ACP agent subprocesses #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement platform-specific sandbox wrapping for ACP agent subprocesses: - macOS: Seatbelt via /usr/bin/sandbox-exec (reusing codex-core) - Linux: Landlock + seccomp via codex-linux-sandbox binary - Windows: Deferred (gracefully degrades to unsandboxed) This restricts what agent processes can access based on SandboxPolicy, providing OS-level security for Claude Code, Codex, and Gemini CLI agents. Key changes: - New sandbox.rs module with transform_command_for_sandbox() - AcpConnection::spawn() now accepts sandbox_policy parameter - Graceful degradation when Linux sandbox binary not provided - Defense-in-depth: application-level path restrictions retained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Nori
sandbox.rsmodule withtransform_command_for_sandbox()to wrap agent commandsAcpConnection::spawn()now acceptssandbox_policyparameter to control sandbox behaviorwrite_text_file()retainedTest Plan
Share Nori with your team: https://www.npmjs.com/package/nori-ai