feat(tui): Add OS-level notifications for approval requests #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements OS-level notifications when the CLI needs user attention: - Add ApprovalRequested variant to UserNotification for approval events - Add IdleDetector to track how long the system has been idle - Bundle notify-hook.sh script for cross-platform notifications - Auto-deploy notify hook to ~/.nori/cli/ on first launch - Configure notify setting in config.toml during onboarding - Integrate UserNotifier into ChatWidget for approval events The notification includes idle duration when the system has been waiting for 5+ seconds before an approval request arrives. 🤖 Generated with [Nori](https://nori.ai) Co-Authored-By: Nori <contact@tilework.tech>
Split `use std::time::{Duration, Instant}` into separate lines as
required by nightly rustfmt on CI.
🤖 Generated with [Nori](https://nori.ai)
Co-Authored-By: Nori <contact@tilework.tech>
Remove the dead code that clippy flagged in CI. 🤖 Generated with [Nori](https://nori.ai) Co-Authored-By: Nori <contact@tilework.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Nori
notify-hook.shscript for cross-platform notifications (Linux, macOS, Windows)Implementation Details
New Components
IdleDetector: Tracks how long the system has been idle, with a 5-second thresholdnotify-hook.sh: Cross-platform shell script bundled with the CLI, deployed to~/.nori/cli/ApprovalRequestednotification type: Includes request type, message, command/files, and idle durationIntegration Points
config.tomlChatWidgetintegratesUserNotifierandIdleDetectorfor approval eventsTest Plan
IdleDetectorlogic (5 tests)ApprovalRequestednotification serialization (3 tests)Share Nori with your team: https://www.npmjs.com/package/nori-ai