feat(cli): Enable --yolo flag for all builds #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the feature gate from the `--yolo` (alias: `--dangerously-bypass-approvals-and-sandbox`) CLI flag so it works in minimal Nori builds without requiring the `codex-features` Cargo feature. When the flag is enabled, it sets: - `SandboxMode::DangerFullAccess` (no filesystem restrictions) - `AskForApproval::Never` (no confirmation prompts) The flag maintains `conflicts_with_all` for codex-features builds to prevent confusing interactions with `--full-auto` and `-a` approval policy flags. 🤖 Generated with [Nori](https://nori.ai) Co-Authored-By: Nori <contact@tilework.tech>
The test `dangerous_bypass_flag_rejected_without_codex_features` was asserting that the flag should be rejected, but we've now deliberately made it available in all builds. Updated the test to verify the flag IS accepted and added a test for the --yolo alias. 🤖 Generated with [Nori](https://nori.ai) Co-Authored-By: Nori <contact@tilework.tech>
The --yolo flag was parsing correctly but the ACP backend was still prompting for approvals. The run_approval_handler function now checks the approval policy and auto-approves immediately when approval_policy == AskForApproval::Never. This completes the data flow: CLI --yolo flag → AskForApproval::Never → AcpBackendConfig → run_approval_handler() → auto-approve 🤖 Generated with [Nori](https://nori.ai) Co-Authored-By: Nori <contact@tilework.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Nori
--yolo(alias:--dangerously-bypass-approvals-and-sandbox) CLI flag so it works in minimal Nori builds without requiring thecodex-featuresCargo featureSandboxMode::DangerFullAccessandAskForApproval::Neverto bypass all safety mechanismsconflicts_with_allfor codex-features builds to prevent confusing interactions with--full-autoand-aflagsTest Plan
Share Nori with your team: https://www.npmjs.com/package/nori-ai