fix(acp): Enable dynamic approval policy updates via /approvals command #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The /approvals command was not working in ACP mode because: - run_approval_handler captured approval_policy by value at spawn time - Op::OverrideTurnContext was ignored in the ACP submit() method This fix uses a tokio::sync::watch channel to broadcast policy changes from AcpBackend::submit() to the long-running approval handler task, enabling mid-session policy changes (e.g., switching to full access mode). Changes: - Add approval_policy_tx watch::Sender field to AcpBackend - Create watch channel in spawn() and pass receiver to handler - Handle Op::OverrideTurnContext to update policy via watch channel - Update run_approval_handler to read current policy on each request 🤖 Generated with [Nori](https://nori.ai) Co-Authored-By: Nori <contact@tilework.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Nori
/approvalscommand was not working in ACP mode - selecting "full access" still prompted for permissionstokio::sync::watchchannel to broadcast approval policy changes fromAcpBackend::submit()to the long-running approval handler taskOp::OverrideTurnContextto update the policy dynamically, making/approvalswork equivalently to--yolowhen full access is selectedTest Plan
test_approval_policy_dynamic_updateunit test that verifies:OnRequestpolicy correctly forwards approval requests to TUINevervia watch channel takes effect immediatelyShare Nori with your team: https://www.npmjs.com/package/nori-ai