feat(tui): Display approval mode in status line footer #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the current approval mode to the footer status line beneath the TUI input area. Shows "Approval Mode: Read Only", "Approval Mode: Agent", or "Approval Mode: Full Access" in magenta, positioned after the git branch and before the skillset. The label updates dynamically when the user changes approval settings via the /approvals command. - Add approval_mode_label helper function to approval_presets.rs - Add approval_mode_label field and rendering to footer.rs - Wire through ChatComposer, BottomPane, and ChatWidget - Add snapshot tests for all three approval modes - Update documentation in common/docs.md and tui/docs.md 🤖 Generated with [Nori](https://nori.ai) Co-Authored-By: Nori <contact@tilework.tech>
Update E2E test snapshots to reflect the new approval mode label displayed in the footer status line. The tests now verify that "Approval Mode: Agent" appears in the footer when using the default trusted project configuration. 🤖 Generated with [Nori](https://nori.ai) Co-Authored-By: Nori <contact@tilework.tech>
On macOS, /tmp is a symlink to /private/tmp. When the E2E tests wrote config.toml with a non-canonicalized temp directory path, the config loader would canonicalize CODEX_HOME and resolved_cwd but fail to match the project trust level because the paths differed. This caused the approval mode to default to ReadOnly instead of using the configured Agent mode, breaking the snapshot test. Fix by canonicalizing the cwd path when generating config.toml in E2E tests, ensuring path matching works correctly on macOS. 🤖 Generated with [Nori](https://nori.ai) Co-Authored-By: Nori <contact@tilework.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Nori
/approvalscommandTest Plan
approval_mode_labelhelper function (5 tests)/approvals, verify footer updatesShare Nori with your team: https://www.npmjs.com/package/nori-ai